From 175b58cb2020d37778d9438899af783f54fe82a3 Mon Sep 17 00:00:00 2001
From: MaverickD650 <92877124+MaverickD650@users.noreply.github.com>
Date: Sat, 8 Jul 2023 19:56:37 +0100
Subject: [PATCH] fix(invidious): patch hmac_key requirement (#10310)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

**Description**
<!--
Please include a summary of the change and which issue is fixed. Please
also include relevant motivation and context. List any dependencies that
are required for this change.
-->
Upstream made the hmac_key mandatory. This PR makes that question
required with explanation a random key is required along with changes to
ensure the chart passes CI. Default value not provided to ensure users
provide a unique value.

⚒️ Fixes  #10309

**⚙️ Type of change**

- [ ] ⚙️ Feature/App addition
- [X] 🪛 Bugfix
- [ ] ⚠️ Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] 🔃 Refactor of current code

**🧪 How Has This Been Tested?**
<!--
Please describe the tests that you ran to verify your changes. Provide
instructions so we can reproduce. Please also list any relevant details
for your test configuration
-->
CI passes on forked branch.

**📃 Notes:**
<!-- Please enter any other relevant information here -->

**✔️ Checklist:**

- [X] ⚖️ My code follows the style guidelines of this project
- [X] 👀 I have performed a self-review of my own code
- [X] #️⃣ I have commented my code, particularly in hard-to-understand
areas
- [ ] 📄 I have made corresponding changes to the documentation
- [X] ⚠️ My changes generate no new warnings
- [ ] 🧪 I have added tests to this description that prove my fix is
effective or that my feature works
- [X] ⬆️ I increased versions for any altered app according to semantic
versioning

**➕ App addition**

If this PR is an app addition please make sure you have done the
following.

- [ ] 🪞 I have opened a PR on
[truecharts/containers](https://github.com/truecharts/containers) adding
the container to TrueCharts mirror repo.
- [ ] 🖼️ I have added an icon in the Chart's root directory called
`icon.png`

---

_Please don't blindly check all the boxes. Read them and only check
those that apply.
Those checkboxes are there for the reviewer to see what is this all
about and
the status of this PR with a quick glance._
---
 charts/stable/invidious/Chart.yaml          | 2 +-
 charts/stable/invidious/ci/test-values.yaml | 3 +++
 charts/stable/invidious/questions.yaml      | 2 +-
 3 files changed, 5 insertions(+), 2 deletions(-)
 create mode 100644 charts/stable/invidious/ci/test-values.yaml

diff --git a/charts/stable/invidious/Chart.yaml b/charts/stable/invidious/Chart.yaml
index b6385afb81a..51abd4dac88 100644
--- a/charts/stable/invidious/Chart.yaml
+++ b/charts/stable/invidious/Chart.yaml
@@ -21,7 +21,7 @@ sources:
   - https://github.com/truecharts/charts/tree/master/charts/stable/invidious
   - https://github.com/iv-org/invidious
   - https://docs.invidious.io/installation/#docker
-version: 5.0.11
+version: 5.1.0
 annotations:
   truecharts.org/catagories: |
     - media
diff --git a/charts/stable/invidious/ci/test-values.yaml b/charts/stable/invidious/ci/test-values.yaml
new file mode 100644
index 00000000000..a768c0a27b1
--- /dev/null
+++ b/charts/stable/invidious/ci/test-values.yaml
@@ -0,0 +1,3 @@
+invidious:
+  miscellaneous:
+    hmac_key: "change_me"
diff --git a/charts/stable/invidious/questions.yaml b/charts/stable/invidious/questions.yaml
index acd0176cd62..deca27317ce 100644
--- a/charts/stable/invidious/questions.yaml
+++ b/charts/stable/invidious/questions.yaml
@@ -342,7 +342,7 @@ questions:
                   default: false
               - variable: hmac_key
                 label: HMAC Key
-                description: HMAC signing key used for CSRF tokens and pubsub subscriptions verification.
+                description: HMAC signing key used for CSRF tokens and pubsub subscriptions verification. A random key must be generated and placed here.
                 schema:
                   type: string
                   private: true