From 389eb05d86c021cdbe37260eec4315d94353c3ae Mon Sep 17 00:00:00 2001 From: Stavros Kois <47820033+stavros-k@users.noreply.github.com> Date: Fri, 12 Aug 2022 12:45:46 +0300 Subject: [PATCH] fix(plex): accept `-` and capital letters in ADVERTISE_IP (#3448) --- charts/stable/plex/Chart.yaml | 2 +- charts/stable/plex/docs/validation.md | 8 ++++++-- charts/stable/plex/questions.yaml | 2 +- 3 files changed, 8 insertions(+), 4 deletions(-) diff --git a/charts/stable/plex/Chart.yaml b/charts/stable/plex/Chart.yaml index af40c7cf988..0d29833ce42 100644 --- a/charts/stable/plex/Chart.yaml +++ b/charts/stable/plex/Chart.yaml @@ -21,7 +21,7 @@ sources: - https://github.com/truecharts/charts/tree/master/charts/stable/plex - https://github.com/k8s-at-home/container-images/pkgs/container/plex type: application -version: 10.0.32 +version: 10.0.33 annotations: truecharts.org/catagories: | - media diff --git a/charts/stable/plex/docs/validation.md b/charts/stable/plex/docs/validation.md index ca1174af74b..049e1809ad3 100644 --- a/charts/stable/plex/docs/validation.md +++ b/charts/stable/plex/docs/validation.md @@ -7,6 +7,7 @@ Accepts: - Empty string - `http://` or `https://` - IP or DNS host +- Characters (`0-9`, `a-z`, `A-Z`, `-`, `.`) - Port is optional - `,` Separated @@ -17,10 +18,13 @@ Accepted formats are: - `http://dnshost:32400` - `https://dnshost:32400` - `https://dnshost` +- `https://DNSHOST` +- `https://DNS-HOST` +- `https://dns-host` - `https://dnshost,http://192.168.1.100:32400` -Regex used to match this: `^$|^(http(s)?:\/\/([a-z0-9.]*)(:\d{0,5})?,?)*$` -You can try live [here](https://regex101.com/r/iC2WYp/1) +Regex used to match this: `^$|^(http(s)?:\/\/([a-zA-Z0-9.-]*)(:\d{0,5})?,?)*$` +You can try live [here](https://regex101.com/r/zay2xO/1) --- diff --git a/charts/stable/plex/questions.yaml b/charts/stable/plex/questions.yaml index 615acf56355..9ade693d9a5 100644 --- a/charts/stable/plex/questions.yaml +++ b/charts/stable/plex/questions.yaml @@ -25,7 +25,7 @@ questions: description: "IP to advertise to Plex, Change SERVER_IP to your actual server IP" schema: type: string - valid_chars: '^$|^(http(s)?:\/\/([a-z0-9.]*)(:\d{0,5})?,?)*$' + valid_chars: '^$|^(http(s)?:\/\/([a-zA-Z0-9.-]*)(:\d{0,5})?,?)*$' default: "http://SERVER_IP:32400" - variable: ALLOWED_NETWORKS label: "Allowed Networks"