Run as PUID/PGID by default and add startAsRoot option (#246)

.gitignore

@@ -41,5 +41,5 @@ tests/test-report.txt
 tests/test-report.xml
 private_values.yaml
 temp/
-library/common-test/charts/*
+library/common-test/charts/
 Chart.lock

.tools/tests/charts/common-test_spec.rb

@@ -38,6 +38,19 @@ class Test < ChartTest
       end
     end
 
+    describe 'startAsRoot' do
+      it 'defaults to false = runAs 568' do
+        jq('.spec.template.spec.securityContext.runAsUser', resource('Deployment')).must_equal 568
+        jq('.spec.template.spec.securityContext.runAsGroup', resource('Deployment')).must_equal 568
+      end
+
+      it 'can be enabled = runAs nil' do
+        chart.value startAsRoot: true
+        jq('.spec.template.spec.securityContext.runAsUser', resource('Deployment')).must_equal nil
+        jq('.spec.template.spec.securityContext.runAsGroup', resource('Deployment')).must_equal nil
+      end
+    end
+
     describe 'hostNetwork' do
       it ' hostnetworking default = nil' do
         jq('.spec.template.spec.hostNetwork', resource('Deployment')).must_equal nil

charts/bazarr/2.0.0/ix_values.yaml

@@ -9,6 +9,8 @@ image:
   pullPolicy: IfNotPresent
   tag: version-v0.9.0.5
 
+startAsRoot: true
+
 ##
 # Most other defaults are set in questions.yaml
 # For other options please refer to the wiki, default_values.yaml or the common library chart

charts/bazarr/2.0.0/test_values.yaml

@@ -8,6 +8,8 @@ image:
 strategy:
   type: Recreate
 
+startAsRoot: true
+
 services:
   main:
     port:

charts/calibre-web/2.0.0/ix_values.yaml

@@ -9,6 +9,8 @@ image:
   pullPolicy: IfNotPresent
   tag: version-0.6.9
 
+startAsRoot: true
+
 ##
 # Most other defaults are set in questions.yaml
 # For other options please refer to the wiki, default_values.yaml or the common library chart

charts/calibre-web/2.0.0/test_values.yaml

@@ -8,6 +8,8 @@ image:
 strategy:
   type: Recreate
 
+startAsRoot: true
+
 services:
   main:
     port:

charts/collabora-online/2.0.0/ix_values.yaml

@@ -9,6 +9,8 @@ image:
   tag: 6.4.6.2
   pullPolicy: IfNotPresent
 
+startAsRoot: true
+
 ##
 # Most other defaults are set in questions.yaml
 # For other options please refer to the wiki, default_values.yaml or the common library chart

charts/collabora-online/2.0.0/test_values.yaml

@@ -6,6 +6,8 @@ image:
 strategy:
   type: Recreate
 
+startAsRoot: true
+
 services:
   main:
     type: NodePort

charts/deluge/2.0.0/ix_values.yaml

@@ -9,6 +9,8 @@ image:
   pullPolicy: IfNotPresent
   tag: latest
 
+startAsRoot: true
+
 ##
 # Most other defaults are set in questions.yaml
 # For other options please refer to the wiki, default_values.yaml or the common library chart

charts/deluge/2.0.0/test_values.yaml

@@ -8,6 +8,8 @@ image:
 strategy:
   type: Recreate
 
+startAsRoot: true
+
 services:
   main:
     port:

charts/esphome/2.0.0/ix_values.yaml

@@ -9,6 +9,8 @@ image:
   pullPolicy: IfNotPresent
   tag: 1.15.3
 
+startAsRoot: true
+
 ##
 # Most other defaults are set in questions.yaml
 # For other options please refer to the wiki, default_values.yaml or the common library chart

charts/esphome/2.0.0/test_values.yaml

@@ -12,7 +12,6 @@ services:
   main:
     port:
       port: 6052
-    nodePort: 30052
 
 env: {}
   # ESPHOME_DASHBOARD_USE_PING: true

charts/freshrss/2.0.0/ix_values.yaml

@@ -9,6 +9,8 @@ image:
   pullPolicy: IfNotPresent
   tag: version-1.17.0
 
+startAsRoot: true
+
 ##
 # Most other defaults are set in questions.yaml
 # For other options please refer to the wiki, default_values.yaml or the common library chart

charts/freshrss/2.0.0/test_values.yaml

@@ -8,6 +8,8 @@ image:
 strategy:
   type: Recreate
 
+startAsRoot: true
+
 services:
   main:
     port:

charts/grocy/2.0.0/ix_values.yaml

@@ -9,6 +9,8 @@ image:
   tag: version-v2.7.1
   pullPolicy: IfNotPresent
 
+startAsRoot: true
+
 ##
 # Most other defaults are set in questions.yaml
 # For other options please refer to the wiki, default_values.yaml or the common library chart

charts/grocy/2.0.0/test_values.yaml

@@ -8,6 +8,8 @@ image:
 strategy:
   type: Recreate
 
+startAsRoot: true
+
 services:
   main:
     port:

charts/handbrake/2.0.0/ix_values.yaml

@@ -9,6 +9,8 @@ image:
   tag: v1.23.1
   pullPolicy: IfNotPresent
 
+startAsRoot: true
+
 #All values here are set as the docker defaults.
 envTpl:
 # Permissions Settings

charts/handbrake/2.0.0/test_values.yaml

@@ -6,6 +6,8 @@ image:
 strategy:
   type: Recreate
 
+startAsRoot: true
+
 services:
   main:
     port:
@@ -23,6 +25,7 @@ envTpl:
 # Permissions Settings
   USER_ID: "{{ .Values.PUID }}"
   GROUP_ID: "{{ .Values.PGID }}"
+
 env:
 # General Settings
   KEEP_APP_RUNNING: "0"

charts/heimdall/2.0.0/ix_values.yaml

@@ -9,6 +9,8 @@ image:
   tag: version-2.2.2
   pullPolicy: IfNotPresent
 
+startAsRoot: true
+
 ##
 # Most other defaults are set in questions.yaml
 # For other options please refer to the wiki, default_values.yaml or the common library chart

charts/heimdall/2.0.0/test_values.yaml

@@ -8,6 +8,8 @@ image:
 strategy:
   type: Recreate
 
+startAsRoot: true
+
 services:
   main:
     port:

charts/home-assistant/2.0.0/ix_values.yaml

@@ -9,6 +9,8 @@ image:
   pullPolicy: IfNotPresent
   tag: 2021.1.5
 
+startAsRoot: true
+
 ##
 # Most other defaults are set in questions.yaml
 # For other options please refer to the wiki, default_values.yaml or the common library chart

charts/home-assistant/2.0.0/test_values.yaml

@@ -8,6 +8,8 @@ image:
 strategy:
   type: Recreate
 
+startAsRoot: true
+
 env: {}
     # TZ:
 

charts/jackett/2.0.0/ix_values.yaml

@@ -9,6 +9,8 @@ image:
   pullPolicy: IfNotPresent
   tag: version-v0.17.153
 
+startAsRoot: true
+
 ##
 # Most other defaults are set in questions.yaml
 # For other options please refer to the wiki, default_values.yaml or the common library chart

charts/jackett/2.0.0/test_values.yaml

@@ -8,6 +8,8 @@ image:
 strategy:
   type: Recreate
 
+startAsRoot: true
+
 services:
   main:
     port:

charts/jellyfin/2.0.0/ix_values.yaml

@@ -9,6 +9,8 @@ image:
   pullPolicy: IfNotPresent
   tag: version-10.6.4-1
 
+startAsRoot: true
+
 ##
 # Most other defaults are set in questions.yaml
 # For other options please refer to the wiki, default_values.yaml or the common library chart

charts/jellyfin/2.0.0/test_values.yaml

@@ -9,6 +9,8 @@ image:
 strategy:
   type: Recreate
 
+startAsRoot: true
+
 services:
   main:
     port:

charts/kms/2.0.0/Chart.yaml

@@ -7,7 +7,7 @@ version: 1.6.4
 version: 2.0.0
 >>>>>>> [Common] Refactor Services (#212):charts/kms/2.0.0/Chart.yaml
 # upstream_version:
-appVersion: "auto"
+appVersion: "minimal"
 description: Private Windows Activation Server for development and testing
 type: application
 deprecated: false

charts/kms/2.0.0/ix_values.yaml

@@ -7,7 +7,9 @@
 image:
   repository: pykmsorg/py-kms
   pullPolicy: IfNotPresent
-  tag: latest
+  tag: minimal
+
+startAsRoot: true
 
 ##
 # Most other defaults are set in questions.yaml

charts/kms/2.0.0/questions.yaml

@@ -176,70 +176,6 @@ questions:
 
 ## TrueCharts Specific
 
-  - variable: appVolumeMounts
-    label: "app storage"
-    group: "Storage and Devices"
-    schema:
-      type: dict
-      attrs:
-        # Config ------------------------
-        - variable: config
-          label: "config dataset"
-          schema:
-            type: dict
-            $ref:
-              - "normalize/ixVolume"
-            attrs:
-              - variable: enabled
-                label: "Enabled"
-                schema:
-                  type: boolean
-                  default: true
-                  required: true
-                  hidden: true
-                  editable: false
-              - variable: setPermissions
-                label: "Automatic Permissions"
-                description: "Automatically set permissions on install"
-                schema:
-                  type: boolean
-                  default: true
-                  hidden: false
-              - variable: emptyDir
-                label: "emptyDir"
-                schema:
-                  type: boolean
-                  default: false
-                  hidden: true
-                  editable: false
-              - variable: datasetName
-                label: "Dataset Name"
-                schema:
-                  type: string
-                  default: "config"
-                  required: true
-                  editable: false
-              - variable: mountPath
-                label: "Mount Path"
-                description: "Path to mount inside the pod"
-                schema:
-                  type: path
-                  required: true
-                  default: "/config"
-                  editable: false
-              - variable: hostPathEnabled
-                label: "host Path Enabled"
-                schema:
-                  type: boolean
-                  default: false
-                  show_subquestions_if: true
-                  subquestions:
-                    - variable: hostPath
-                      label: "Host Path"
-                      schema:
-                        type: hostpath
-                        required: true
-
   - variable: additionalAppVolumeMounts
     label: "Custom app storage"
     group: "Storage and Devices"

charts/kms/2.0.0/test_values.yaml

@@ -3,34 +3,14 @@
 image:
   repository: pykmsorg/py-kms
   pullPolicy: IfNotPresent
-  tag: latest
+  tag: minimal
 
 strategy:
   type: Recreate
 
+startAsRoot: true
+
 services:
   main:
     port:
       port: 1688
-
-env: {}
-  # TZ: UTC
-  # PUID: 1001
-  # PGID: 1001
-
-
-persistence:
-  config:
-    enabled: false
-    emptyDir: false
-
-
-## TrueCharts Values
-
-
-appVolumeMounts:
-  config:
-    enabled: true
-    emptyDir: true
-    setPermissions: true
-    mountPath: "/config"

charts/lazylibrarian/2.0.0/ix_values.yaml

@@ -9,6 +9,8 @@ image:
   pullPolicy: IfNotPresent
   tag: latest
 
+startAsRoot: true
+
 ##
 # Most other defaults are set in questions.yaml
 # For other options please refer to the wiki, default_values.yaml or the common library chart

charts/lazylibrarian/2.0.0/test_values.yaml

@@ -8,6 +8,8 @@ image:
 strategy:
   type: Recreate
 
+startAsRoot: true
+
 services:
   main:
     port:

charts/lidarr/2.0.0/ix_values.yaml

@@ -8,6 +8,9 @@ image:
   repository: linuxserver/lidarr
   pullPolicy: IfNotPresent
   tag: version-0.8.0.1886
+
+startAsRoot: true
+
 probes:
     liveness:
       enabled: true

charts/lidarr/2.0.0/test_values.yaml

@@ -8,6 +8,8 @@ image:
 strategy:
   type: Recreate
 
+startAsRoot: true
+
 services:
   main:
     port:

charts/lychee/2.0.0/ix_values.yaml

@@ -9,6 +9,8 @@ image:
   pullPolicy: IfNotPresent
   tag: v4.0.8
 
+startAsRoot: true
+
 ##
 # Most other defaults are set in questions.yaml
 # For other options please refer to the wiki, default_values.yaml or the common library chart

charts/lychee/2.0.0/test_values.yaml

@@ -8,6 +8,8 @@ image:
 strategy:
   type: Recreate
 
+startAsRoot: true
+
 services:
   main:
     port:

charts/node-red/2.0.0/test_values.yaml

@@ -38,4 +38,4 @@ appVolumeMounts:
     enabled: true
     emptyDir: true
     setPermissions: true
-    mountPath: "/config"
+    mountPath: "/data"

charts/nzbget/2.0.0/ix_values.yaml

@@ -9,6 +9,8 @@ image:
   pullPolicy: IfNotPresent
   tag: version-v21.0
 
+startAsRoot: true
+
 ##
 # Most other defaults are set in questions.yaml
 # For other options please refer to the wiki, default_values.yaml or the common library chart

charts/nzbget/2.0.0/test_values.yaml

@@ -8,6 +8,8 @@ image:
 strategy:
   type: Recreate
 
+startAsRoot: true
+
 services:
   main:
     port:

charts/nzbhydra/2.0.0/ix_values.yaml

@@ -9,6 +9,8 @@ image:
   pullPolicy: IfNotPresent
   tag: version-v3.8.1
 
+startAsRoot: true
+
 probes:
   liveness:
     custom: true

charts/nzbhydra/2.0.0/test_values.yaml

@@ -8,6 +8,8 @@ image:
 strategy:
   type: Recreate
 
+startAsRoot: true
+
 services:
   main:
     port:

charts/ombi/2.0.0/ix_values.yaml

@@ -9,6 +9,8 @@ image:
   pullPolicy: IfNotPresent
   tag: version-v4.0.681
 
+startAsRoot: true
+
 ##
 # Most other defaults are set in questions.yaml
 # For other options please refer to the wiki, default_values.yaml or the common library chart

charts/ombi/2.0.0/test_values.yaml

@@ -9,6 +9,8 @@ image:
 strategy:
   type: Recreate
 
+startAsRoot: true
+
 services:
   main:
     port:

charts/organizr/2.0.0/ix_values.yaml

@@ -9,6 +9,8 @@ image:
   pullPolicy: Always
   tag: latest
 
+startAsRoot: true
+
 ##
 # Most other defaults are set in questions.yaml
 # For other options please refer to the wiki, default_values.yaml or the common library chart

charts/organizr/2.0.0/test_values.yaml

@@ -9,6 +9,8 @@ image:
 strategy:
   type: Recreate
 
+startAsRoot: true
+
 services:
   main:
     port:

charts/qbittorrent/2.0.0/ix_values.yaml

@@ -9,6 +9,8 @@ image:
   pullPolicy: IfNotPresent
   tag: latest
 
+startAsRoot: true
+
 ##
 # Most other defaults are set in questions.yaml
 # For other options please refer to the wiki, default_values.yaml or the common library chart

charts/qbittorrent/2.0.0/test_values.yaml

@@ -8,6 +8,8 @@ image:
 strategy:
   type: Recreate
 
+startAsRoot: true
+
 env: {}
     # TZ: UTC
   # PUID: 1001

charts/radarr/2.0.0/ix_values.yaml

@@ -9,6 +9,8 @@ image:
   pullPolicy: IfNotPresent
   tag: version-3.0.0.3989
 
+startAsRoot: true
+
 probes:
   liveness:
     enabled: true

charts/radarr/2.0.0/test_values.yaml

@@ -8,6 +8,8 @@ image:
 strategy:
   type: Recreate
 
+startAsRoot: true
+
 services:
   main:
     port:

charts/readarr/2.0.0/ix_values.yaml

@@ -9,6 +9,8 @@ image:
   pullPolicy: IfNotPresent
   tag: nightly
 
+startAsRoot: true
+
 probes:
     liveness:
       enabled: true

charts/readarr/2.0.0/test_values.yaml

@@ -8,6 +8,8 @@ image:
 strategy:
   type: Recreate
 
+startAsRoot: true
+
 services:
   main:
     port:

charts/sabnzbd/2.0.0/ix_values.yaml

@@ -9,6 +9,8 @@ image:
   pullPolicy: IfNotPresent
   tag: version-3.1.0
 
+startAsRoot: true
+
 ##
 # Most other defaults are set in questions.yaml
 # For other options please refer to the wiki, default_values.yaml or the common library chart

charts/sabnzbd/2.0.0/test_values.yaml

@@ -8,6 +8,8 @@ image:
 strategy:
   type: Recreate
 
+startAsRoot: true
+
 services:
   main:
     port:

charts/sonarr/2.0.0/ix_values.yaml

@@ -9,6 +9,8 @@ image:
   pullPolicy: IfNotPresent
   tag: version-3.0.4.993
 
+startAsRoot: true
+
 probes:
     liveness:
     enabled: true

charts/sonarr/2.0.0/test_values.yaml

@@ -8,6 +8,8 @@ image:
 strategy:
   type: Recreate
 
+startAsRoot: true
+
 services:
   main:
     port:

charts/tautulli/2.0.0/ix_values.yaml

@@ -9,6 +9,8 @@ image:
   pullPolicy: IfNotPresent
   tag: v2.6.6
 
+startAsRoot: true
+
 ##
 # Most other defaults are set in questions.yaml
 # For other options please refer to the wiki, default_values.yaml or the common library chart

charts/tautulli/2.0.0/test_values.yaml

@@ -8,6 +8,8 @@ image:
 strategy:
   type: Recreate
 
+startAsRoot: true
+
 services:
   main:
     port:

charts/transmission/2.0.0/ix_values.yaml

@@ -9,6 +9,8 @@ image:
   pullPolicy: IfNotPresent
   tag: version-3.00-r2
 
+startAsRoot: true
+
 ##
 # Most other defaults are set in questions.yaml
 # For other options please refer to the wiki, default_values.yaml or the common library chart

charts/transmission/2.0.0/test_values.yaml

@@ -8,6 +8,8 @@ image:
 strategy:
   type: Recreate
 
+startAsRoot: true
+
 services:
   main:
     port:

charts/truecommand/2.0.0/ix_values.yaml

@@ -9,6 +9,8 @@ image:
   pullPolicy: IfNotPresent
   tag: 1.3.2
 
+startAsRoot: true
+
 ##
 # Most other defaults are set in questions.yaml
 # For other options please refer to the wiki, default_values.yaml or the common library chart

charts/truecommand/2.0.0/test_values.yaml

@@ -8,6 +8,8 @@ image:
 strategy:
   type: Recreate
 
+startAsRoot: true
+
 services:
   main:
     port:
@@ -40,9 +42,6 @@ persistence:
 
 ## TrueCharts Config
 
-
-
-
 appVolumeMounts:
   data:
     enabled: true

charts/tvheadend/2.0.0/ix_values.yaml

@@ -9,6 +9,8 @@ image:
   pullPolicy: IfNotPresent
   tag: latest
 
+startAsRoot: true
+
 ##
 # Most other defaults are set in questions.yaml
 # For other options please refer to the wiki, default_values.yaml or the common library chart

charts/tvheadend/2.0.0/test_values.yaml

@@ -8,6 +8,8 @@ image:
 strategy:
   type: Recreate
 
+startAsRoot: true
+
 # See https://github.com/linuxserver/docker-tvheadend#parameters
 env: {}
   # PUID: 1000

charts/unifi/2.0.0/ix_values.yaml

@@ -9,6 +9,13 @@ image:
   tag: 6.0.45
   pullPolicy: IfNotPresent
 
+startAsRoot: true
+
+envTpl:
+# Permissions Settings
+  UNIFI_GID: "{{ .Values.PUID }}"
+  UNIFI_UID: "{{ .Values.PGID }}"
+
 ##
 # Most other defaults are set in questions.yaml
 # For other options please refer to the wiki, default_values.yaml or the common library chart

charts/unifi/2.0.0/test_values.yaml

@@ -8,6 +8,13 @@ image:
 strategy:
   type: Recreate
 
+startAsRoot: true
+
+envTpl:
+# Permissions Settings
+  UNIFI_GID: "{{ .Values.PUID }}"
+  UNIFI_UID: "{{ .Values.PGID }}"
+
 services:
   main:
     port: