From 580693309985f2e21e9525a338ad83701788bdd4 Mon Sep 17 00:00:00 2001
From: v3DJG6GL <72495210+v3DJG6GL@users.noreply.github.com>
Date: Thu, 30 May 2024 14:55:21 +0200
Subject: [PATCH] fix(whisper-asr-webservice): switch readiness and startup
 probe to tcp, update app version (#21439)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

**Description**
<!--
Please include a summary of the change and which issue is fixed. Please
also include relevant motivation and context. List any dependencies that
are required for this change.
-->
⚒️ Fixes  # <!--(issue)-->

**⚙️ Type of change**
This PR fixes a problem with `readiness` and `startup` probes: changing
the `liveness` probe to `tcp` in #20042 was obviously not enough to
prevent the app from always killing.
Also, I updated the app version. Something with the automatic updates
doesn't seem to work with this app.
- [ ] ⚙️ Feature/App addition
- [ ] 🪛 Bugfix
- [ ] ⚠️ Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] 🔃 Refactor of current code

**🧪 How Has This Been Tested?**
<!--
Please describe the tests that you ran to verify your changes. Provide
instructions so we can reproduce. Please also list any relevant details
for your test configuration
-->

**📃 Notes:**
<!-- Please enter any other relevant information here -->

**✔️ Checklist:**

- [X] ⚖️ My code follows the style guidelines of this project
- [X] 👀 I have performed a self-review of my own code
- [ ] #️⃣ I have commented my code, particularly in hard-to-understand
areas
- [ ] 📄 I have made corresponding changes to the documentation
- [ ] ⚠️ My changes generate no new warnings
- [ ] 🧪 I have added tests to this description that prove my fix is
effective or that my feature works
- [X] ⬆️ I increased versions for any altered app according to semantic
versioning
- [X] I made sure the title starts with `feat(chart-name):`,
`fix(chart-name):` or `chore(chart-name):`

**➕ App addition**

If this PR is an app addition please make sure you have done the
following.

- [ ] 🖼️ I have added an icon in the Chart's root directory called
`icon.png`

---

_Please don't blindly check all the boxes. Read them and only check
those that apply.
Those checkboxes are there for the reviewer to see what is this all
about and
the status of this PR with a quick glance._

---------

Signed-off-by: v3DJG6GL <72495210+v3DJG6GL@users.noreply.github.com>
Signed-off-by: StevenMcElligott <89483932+StevenMcElligott@users.noreply.github.com>
Signed-off-by: Kjeld Schouten <kjeld@schouten-lebbing.nl>
Co-authored-by: StevenMcElligott <89483932+StevenMcElligott@users.noreply.github.com>
Co-authored-by: Kjeld Schouten <kjeld@schouten-lebbing.nl>
---
 charts/stable/whisper-asr-webservice/Chart.yaml  |  2 +-
 charts/stable/whisper-asr-webservice/values.yaml | 10 ++++------
 2 files changed, 5 insertions(+), 7 deletions(-)

diff --git a/charts/stable/whisper-asr-webservice/Chart.yaml b/charts/stable/whisper-asr-webservice/Chart.yaml
index 855945e5088..8c1ab8b89ee 100644
--- a/charts/stable/whisper-asr-webservice/Chart.yaml
+++ b/charts/stable/whisper-asr-webservice/Chart.yaml
@@ -7,7 +7,7 @@ annotations:
   truecharts.org/min_helm_version: "3.11"
   truecharts.org/train: stable
 apiVersion: v2
-appVersion: 1.3.0
+appVersion: 1.4.1
 dependencies:
   - name: common
     version: 23.0.10
diff --git a/charts/stable/whisper-asr-webservice/values.yaml b/charts/stable/whisper-asr-webservice/values.yaml
index f65dbca530e..04ae561732d 100644
--- a/charts/stable/whisper-asr-webservice/values.yaml
+++ b/charts/stable/whisper-asr-webservice/values.yaml
@@ -1,11 +1,11 @@
 image:
   repository: onerahmet/openai-whisper-asr-webservice
   pullPolicy: IfNotPresent
-  tag: "v1.3.0@sha256:9332d6faf787ce42886f5e220f3cea801d8530251991192c470847e9efb1239e\r"
+  tag: "v1.4.1@sha256:0105a8e87df7420989f1aa23970e0dee5a0d1557d03ea79d15297c36b2601464\r"
 gpuImage:
   repository: onerahmet/openai-whisper-asr-webservice
   pullPolicy: IfNotPresent
-  tag: "v1.3.0-gpu@sha256:61a54aca45045aa04e31c27ef098890ab196696cc15c55875fb9f0c6ed804456\r"
+  tag: "v1.4.1-gpu@sha256:7cb13a796fbca157e3508c14c3f78234aa3bcb9a08d86e7ceb2c912ca911a130\r"
 securityContext:
   container:
     readOnlyRootFilesystem: false
@@ -22,11 +22,9 @@ workload:
             liveness:
               type: tcp
             readiness:
-              type: http
-              path: "/docs"
+              type: tcp
             startup:
-              type: http
-              path: "/docs"
+              type: tcp
           env:
             ASR_MODEL: tiny
             ASR_ENGINE: faster_whisper