From 6aecb283bb8c708313acc4722d6668f4baecc94c Mon Sep 17 00:00:00 2001 From: Morgan Hunter <32530812+mxc42@users.noreply.github.com> Date: Fri, 31 May 2024 11:32:41 -0400 Subject: [PATCH] fix(adguardhome-sync): deprecated variable update, boolean values (#22694) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit **Description** See deprecation notice here: [https://github.com/bakito/adguardhome-sync/wiki/Deprecations#deprecation-of-environment-variables-as-of-v060](https://github.com/bakito/adguardhome-sync/wiki/Deprecations#deprecation-of-environment-variables-as-of-v060) Also change boolean values to bool instead of string, hopefully fixes this error when running `heavyscript update` on Scale: ``` adguardhome-sync Failed to update. Manual intervention may be required. Validation errors: * values.workload.main.podSpec.containers.main.env.FEATURES_CLIENTSETTINGS: Not a boolean * values.workload.main.podSpec.containers.main.env.FEATURES_DHCP_SERVERCONFIG: Not a boolean * values.workload.main.podSpec.containers.main.env.FEATURES_DHCP_STATICLEASES: Not a boolean * values.workload.main.podSpec.containers.main.env.FEATURES_DNS_ACCESSLISTS: Not a boolean * values.workload.main.podSpec.containers.main.env.FEATURES_DNS_REWRITES: Not a boolean * values.workload.main.pod... For full error details, visit TrueNAS SCALE GUI: Check the Jobs icon and select your failed job. ``` **โš™๏ธ Type of change** - [ ] โš™๏ธ Feature/App addition - [x] ๐Ÿช› Bugfix - [ ] โš ๏ธ Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] ๐Ÿ”ƒ Refactor of current code **๐Ÿงช How Has This Been Tested?** It has not. If there is a good way for me to test, let me know and I will. **๐Ÿ“ƒ Notes:** Not sure if changing variable names is breaking, will people have to reinput them? If so close and I can bump minor version instead of patch. Or if there's a way to direct the chart how to rename current values let me know and I'll do that. **โœ”๏ธ Checklist:** - [x] โš–๏ธ My code follows the style guidelines of this project - [x] ๐Ÿ‘€ I have performed a self-review of my own code - [ ] #๏ธโƒฃ I have commented my code, particularly in hard-to-understand areas - [ ] ๐Ÿ“„ I have made corresponding changes to the documentation - [ ] โš ๏ธ My changes generate no new warnings - [ ] ๐Ÿงช I have added tests to this description that prove my fix is effective or that my feature works - [x] โฌ†๏ธ I increased versions for any altered app according to semantic versioning - [x] I made sure the title starts with `feat(chart-name):`, `fix(chart-name):` or `chore(chart-name):` **โž• App addition** If this PR is an app addition please make sure you have done the following. - [ ] ๐Ÿ–ผ๏ธ I have added an icon in the Chart's root directory called `icon.png` --- _Please don't blindly check all the boxes. Read them and only check those that apply. Those checkboxes are there for the reviewer to see what is this all about and the status of this PR with a quick glance._ --------- Signed-off-by: Morgan Hunter <32530812+mxc42@users.noreply.github.com> --- charts/stable/adguardhome-sync/Chart.yaml | 2 +- charts/stable/adguardhome-sync/values.yaml | 28 +++++++++++----------- 2 files changed, 15 insertions(+), 15 deletions(-) diff --git a/charts/stable/adguardhome-sync/Chart.yaml b/charts/stable/adguardhome-sync/Chart.yaml index 701fb41fc61..5e546f9c377 100644 --- a/charts/stable/adguardhome-sync/Chart.yaml +++ b/charts/stable/adguardhome-sync/Chart.yaml @@ -34,4 +34,4 @@ sources: - https://github.com/bakito/adguardhome-sync/ - https://github.com/truecharts/charts/tree/master/charts/stable/adguardhome-sync type: application -version: 7.0.11 +version: 7.0.12 diff --git a/charts/stable/adguardhome-sync/values.yaml b/charts/stable/adguardhome-sync/values.yaml index 150a9efab4c..76eb9e9e7fd 100644 --- a/charts/stable/adguardhome-sync/values.yaml +++ b/charts/stable/adguardhome-sync/values.yaml @@ -21,23 +21,23 @@ workload: - run env: CRON: "*/10 * * * *" - FEATURES_CLIENTSETTINGS: "true" - FEATURES_DHCP_SERVERCONFIG: "true" - FEATURES_DHCP_STATICLEASES: "true" - FEATURES_DNS_ACCESSLISTS: "true" - FEATURES_DNS_REWRITES: "true" - FEATURES_DNS_SERVERCONFIG: "true" - FEATURES_FILTERS: "true" - FEATURES_GENERALSETTINGS: "true" - FEATURES_QUERYLOGCONFIG: "true" - FEATURES_SERVICES: "true" - FEATURES_STATSCONFIG: "true" + FEATURES_CLIENT_SETTINGS: true + FEATURES_DHCP_SERVER_CONFIG: true + FEATURES_DHCP_STATIC_LEASES: true + FEATURES_DNS_ACCESS_LISTS: true + FEATURES_DNS_REWRITES: true + FEATURES_DNS_SERVER_CONFIG: true + FEATURES_FILTERS: true + FEATURES_GENERAL_SETTINGS: true + FEATURES_QUERY_LOG_CONFIG: true + FEATURES_SERVICES: true + FEATURES_STATS_CONFIG: true ORIGIN_PASSWORD: password ORIGIN_URL: https://192.168.1.2:3000 ORIGIN_USERNAME: username - REPLICA_AUTOSETUP: "false" - REPLICA_INTERFACENAME: "" + REPLICA_AUTO_SETUP: false + REPLICA_INTERFACE_NAME: "" REPLICA_PASSWORD: password REPLICA_URL: http://192.168.1.3 REPLICA_USERNAME: username - RUNONSTART: "true" + RUN_ON_START: true