From 96c4f4933ab5ff80b4aba7bdff2be7b14de5c754 Mon Sep 17 00:00:00 2001 From: StevenMcElligott <89483932+StevenMcElligott@users.noreply.github.com> Date: Tue, 25 Jul 2023 05:40:11 -0400 Subject: [PATCH] fix(channels-dvr): Add root permissions to fix TVE (#10813) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit **Description** A user on discord found the fix for the TVE issue -> https://discord.com/channels/830763548678291466/1014121707587522590/1132933759746969641 This was still show up despite previous fixes so root user it is ⚒️ Fixes #9336 **⚙️ Type of change** - [ ] ⚙️ Feature/App addition - [x] 🪛 Bugfix - [ ] ⚠️ Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] 🔃 Refactor of current code **🧪 How Has This Been Tested?** **📃 Notes:** **✔️ Checklist:** - [x] ⚖️ My code follows the style guidelines of this project - [ ] 👀 I have performed a self-review of my own code - [ ] #️⃣ I have commented my code, particularly in hard-to-understand areas - [ ] 📄 I have made corresponding changes to the documentation - [ ] ⚠️ My changes generate no new warnings - [ ] 🧪 I have added tests to this description that prove my fix is effective or that my feature works - [x] ⬆️ I increased versions for any altered app according to semantic versioning **➕ App addition** If this PR is an app addition please make sure you have done the following. - [ ] 🪞 I have opened a PR on [truecharts/containers](https://github.com/truecharts/containers) adding the container to TrueCharts mirror repo. - [ ] 🖼️ I have added an icon in the Chart's root directory called `icon.png` --- _Please don't blindly check all the boxes. Read them and only check those that apply. Those checkboxes are there for the reviewer to see what is this all about and the status of this PR with a quick glance._ --------- Signed-off-by: Kjeld Schouten Co-authored-by: Kjeld Schouten --- charts/stable/channels-dvr/Chart.yaml | 2 +- charts/stable/channels-dvr/questions.yaml | 4 ++-- charts/stable/channels-dvr/values.yaml | 6 ++++++ 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/charts/stable/channels-dvr/Chart.yaml b/charts/stable/channels-dvr/Chart.yaml index 63371a67815..4e8526345d6 100644 --- a/charts/stable/channels-dvr/Chart.yaml +++ b/charts/stable/channels-dvr/Chart.yaml @@ -19,7 +19,7 @@ name: channels-dvr sources: - https://github.com/truecharts/charts/tree/master/charts/stable/channels-dvr type: application -version: 2.1.1 +version: 2.1.2 annotations: truecharts.org/catagories: | - media diff --git a/charts/stable/channels-dvr/questions.yaml b/charts/stable/channels-dvr/questions.yaml index 78af0b7e0da..f12d2d70d59 100644 --- a/charts/stable/channels-dvr/questions.yaml +++ b/charts/stable/channels-dvr/questions.yaml @@ -83,13 +83,13 @@ questions: description: "The UserID of the user running the application" schema: type: int - default: 568 + default: 0 - variable: runAsGroup label: "runAsGroup" description: "The groupID this App of the user running the application" schema: type: int - default: 568 + default: 0 # Include{securityContextContainer} # Include{securityContextAdvanced} # Include{securityContextPod} diff --git a/charts/stable/channels-dvr/values.yaml b/charts/stable/channels-dvr/values.yaml index 5d1b32a5b65..457eb9cc3c0 100644 --- a/charts/stable/channels-dvr/values.yaml +++ b/charts/stable/channels-dvr/values.yaml @@ -8,6 +8,12 @@ tveImage: pullPolicy: Always tag: latest@sha256:7e0130ad244e07f3714edadecdcc8711d9d3c11eac8409705b5c6aa8e108ca7e +securityContext: + container: + readOnlyRootFilesystem: false + runAsUser: 0 + runAsGroup: 0 + service: main: ports: