From ade7976dc083c8f2beb01b538992f0351a4cee0b Mon Sep 17 00:00:00 2001
From: kqmaverick <121722567+kqmaverick@users.noreply.github.com>
Date: Wed, 28 Feb 2024 16:55:29 -0800
Subject: [PATCH] fix(qbittorrent): make auto port forward sidecar a cronjob
 (#18716)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

**Description**
Changes auto port forward sidecar to a cronjob. Also sets the qbitorrent
webui admin password as private.

⚒️ Fixes  # <!--(issue)-->

**⚙️ Type of change**

- [ ] ⚙️ Feature/App addition
- [X] 🪛 Bugfix
- [ ] ⚠️ Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] 🔃 Refactor of current code

**🧪 How Has This Been Tested?**

**📃 Notes:**

**✔️ Checklist:**

- [ ] ⚖️ My code follows the style guidelines of this project
- [ ] 👀 I have performed a self-review of my own code
- [ ] #️⃣ I have commented my code, particularly in hard-to-understand
areas
- [ ] 📄 I have made corresponding changes to the documentation
- [ ] ⚠️ My changes generate no new warnings
- [ ] 🧪 I have added tests to this description that prove my fix is
effective or that my feature works
- [X] ⬆️ I increased versions for any altered app according to semantic
versioning

**➕ App addition**

If this PR is an app addition please make sure you have done the
following.

- [ ] 🖼️ I have added an icon in the Chart's root directory called
`icon.png`

---

_Please don't blindly check all the boxes. Read them and only check
those that apply.
Those checkboxes are there for the reviewer to see what is this all
about and
the status of this PR with a quick glance._

---------

Signed-off-by: kqmaverick <121722567+kqmaverick@users.noreply.github.com>
Co-authored-by: Stavros Kois <47820033+stavros-k@users.noreply.github.com>
---
 charts/stable/qbittorrent/Chart.yaml     | 2 +-
 charts/stable/qbittorrent/questions.yaml | 1 +
 charts/stable/qbittorrent/values.yaml    | 6 +++---
 3 files changed, 5 insertions(+), 4 deletions(-)

diff --git a/charts/stable/qbittorrent/Chart.yaml b/charts/stable/qbittorrent/Chart.yaml
index 8f7c2569b6b..e3600a09ffe 100644
--- a/charts/stable/qbittorrent/Chart.yaml
+++ b/charts/stable/qbittorrent/Chart.yaml
@@ -35,4 +35,4 @@ sources:
   - https://ghcr.io/onedr0p/qbittorrent
   - https://hub.docker.com/r/mjmeli/qbittorrent-port-forward-gluetun-server
 type: application
-version: 19.1.3
+version: 19.1.4
diff --git a/charts/stable/qbittorrent/questions.yaml b/charts/stable/qbittorrent/questions.yaml
index 03c534a463d..783670c225c 100644
--- a/charts/stable/qbittorrent/questions.yaml
+++ b/charts/stable/qbittorrent/questions.yaml
@@ -38,6 +38,7 @@ questions:
                 description: qBittorrent WebUI Password
                 schema:
                   type: string
+                  private: true
                   default: "adminadmin"
 # Include{podOptions}
 # Include{serviceRoot}
diff --git a/charts/stable/qbittorrent/values.yaml b/charts/stable/qbittorrent/values.yaml
index c0fd0cdc4d3..fe3932a06c4 100644
--- a/charts/stable/qbittorrent/values.yaml
+++ b/charts/stable/qbittorrent/values.yaml
@@ -39,9 +39,8 @@ service:
 workload:
   qbitportforward:
     enabled: true
-    type: Deployment
-    strategy: RollingUpdate
-    replicas: 1
+    type: CronJob
+    schedule: "*/5 * * * *"
     podSpec:
       containers:
         qbitportforward:
@@ -60,6 +59,7 @@ workload:
             QBT_PASSWORD: "{{ .Values.qbitportforward.QBT_PASSWORD }}"
             QBT_ADDR: '{{ printf "http://%v:%v" (include "tc.v1.common.lib.chart.names.fullname" $) .Values.service.main.ports.main.port }}'
             GTN_ADDR: '{{ printf "http://%v-gluetun:8000" (include "tc.v1.common.lib.chart.names.fullname" $) }}'
+          command: /usr/src/app/main.sh 
 persistence:
   config:
     enabled: true