feat(dashy) Support for Dashy 3.0.0 (#21294)

**Description**
<!--
Please include a summary of the change and which issue is fixed. Please
also include relevant motivation and context. List any dependencies that
are required for this change.
-->
⚒️ Fixes  # <!--(issue)-->
This PR is supposed to fix this
[issue](https://github.com/truecharts/charts/issues/21293).
Support for Dashy v3.0.0 and its breaking changes.
Tested locally on TrueNAS Scale Dragonfish using Helm commands.

**⚙️ Type of change**

- [ ] ⚙️ Feature/App addition
- [ ] 🪛 Bugfix
- [x] ⚠️ Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] 🔃 Refactor of current code

**🧪 How Has This Been Tested?**
<!--
Please describe the tests that you ran to verify your changes. Provide
instructions so we can reproduce. Please also list any relevant details
for your test configuration
-->

**📃 Notes:**
<!-- Please enter any other relevant information here -->

**✔️ Checklist:**

- [x] ⚖️ My code follows the style guidelines of this project
- [x] 👀 I have performed a self-review of my own code
- [x] #️⃣ I have commented my code, particularly in hard-to-understand
areas
- [ ] 📄 I have made corresponding changes to the documentation
- [x] ⚠️ My changes generate no new warnings
- [ ] 🧪 I have added tests to this description that prove my fix is
effective or that my feature works
- [x] ⬆️ I increased versions for any altered app according to semantic
versioning
- [x] I made sure the title starts with `feat(chart-name):`,
`fix(chart-name):` or `chore(chart-name):`

** App addition**

If this PR is an app addition please make sure you have done the
following.

- [ ] 🖼️ I have added an icon in the Chart's root directory called
`icon.png`

---

_Please don't blindly check all the boxes. Read them and only check
those that apply.
Those checkboxes are there for the reviewer to see what is this all
about and
the status of this PR with a quick glance._
This commit is contained in:
SolidSly 2024-04-26 12:11:38 +02:00 committed by GitHub
parent 033f12bd62
commit c511f4ad4c
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
5 changed files with 27 additions and 20 deletions

View File

@ -7,7 +7,7 @@ annotations:
truecharts.org/min_helm_version: "3.11" truecharts.org/min_helm_version: "3.11"
truecharts.org/train: stable truecharts.org/train: stable
apiVersion: v2 apiVersion: v2
appVersion: 2.1.2 appVersion: 3.0.0
dependencies: dependencies:
- name: common - name: common
version: 20.3.11 version: 20.3.11
@ -33,4 +33,4 @@ sources:
- https://github.com/truecharts/charts/tree/master/charts/stable/dashy - https://github.com/truecharts/charts/tree/master/charts/stable/dashy
- https://hub.docker.com/r/lissy93/dashy - https://hub.docker.com/r/lissy93/dashy
type: application type: application
version: 6.8.13 version: 7.0.0

View File

@ -39,6 +39,13 @@ All our charts have dedicated documentation pages.
The documentation for this chart can be found here: The documentation for this chart can be found here:
https://truecharts.org/charts/stable/dashy https://truecharts.org/charts/stable/dashy
## Upgrade to version 3.0.0
From version 3.0.0, Dashy introduced some breaking changes. Some of them will not impact users such as the change from port 80 to 8080.
However, from now on, the application expects a folder to be mounted instead of a file.
More information about breaking changes can be found [here](https://github.com/Lissy93/dashy/releases/tag/3.0.0).
## Support ## Support

View File

@ -19,22 +19,22 @@ questions:
type: dict type: dict
attrs: attrs:
- variable: enabled - variable: enabled
label: Enable Config File Mount label: Enable Config Folder Mount
description: Mounts a config file from the given host path description: Mounts a config folder from the given host path
schema: schema:
type: boolean type: boolean
default: false default: false
show_subquestions_if: true show_subquestions_if: true
subquestions: subquestions:
- variable: configFileHostPath - variable: configDirectoryHostPath
label: Config File Host Path label: Config Directory Host Path
description: Absolute host path of the config file description: Absolute host path of the config directory
schema: schema:
type: string type: string
default: "" default: ""
- variable: configFileHostReadOnly - variable: configDirectoryHostReadOnly
label: Config File Read Only label: Config Directory Read Only
description: Mount config file as read Only description: Mount config directory as read Only
schema: schema:
type: boolean type: boolean
default: true default: true

View File

@ -16,10 +16,10 @@ items:
{{- define "dashy.confighostpath" -}} {{- define "dashy.confighostpath" -}}
enabled: true enabled: true
type: hostPath type: hostPath
readOnly: {{ .Values.dashy.configFileHostReadOnly }} readOnly: {{ .Values.dashy.configDirectoryHostReadOnly }}
hostPathType: File hostPathType: Directory
hostPath: {{ .Values.dashy.configFileHostPath }} hostPath: {{ .Values.dashy.configDirectoryHostPath }}
mountPath: /app/public/conf.yml mountPath: /app/user-data/
{{- end -}} {{- end -}}
{{- if .Values.dashyConfig -}} {{- if .Values.dashyConfig -}}

View File

@ -1,6 +1,6 @@
image: image:
repository: lissy93/dashy repository: lissy93/dashy
tag: 2.1.2@sha256:3826f7300f1b476815c5af9071fc7172f4233178e9b46dbc5a846fcc5748a3a1 tag: 3.0.0@sha256:ee064a7a0ae7f480523df95cf87c7a3200911aa961b6c19237a13acf6347f981
pullPolicy: IfNotPresent pullPolicy: IfNotPresent
securityContext: securityContext:
container: container:
@ -14,13 +14,13 @@ service:
main: main:
port: 10310 port: 10310
protocol: http protocol: http
targetPort: 80 targetPort: 8080
dashy: dashy:
# Enable config file mount from host path # Enable config directory mount from host path
enabled: false enabled: false
configFileHostPath: "" configDirectoryHostPath: ""
configFileHostReadOnly: true configDirectoryHostReadOnly: true
# Leave empty if you plan to use config file from host path # Leave empty if you plan to use config directory from host path
dashyConfig: {} dashyConfig: {}
# pageInfo: # pageInfo:
# title: Home Lab # title: Home Lab