fix(livestreamdvr) remove a redundant variable and housekeeping. (#16377)

**Description**
Remove the UMASK variable from the gui
update and add the variables to the gui and values
update the storage variables and description
⚒️ Fixes  # <!--(issue)-->

**⚙️ Type of change**

- [X] ⚙️ Feature/App addition
- [ ] 🪛 Bugfix
- [ ] ⚠️ Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [X] 🔃 Refactor of current code

**🧪 How Has This Been Tested?**
<!--
Please describe the tests that you ran to verify your changes. Provide
instructions so we can reproduce. Please also list any relevant details
for your test configuration
-->

**📃 Notes:**
This was bulk moved to stable from incubator; so marking it as breaking
will be redundant.
**✔️ Checklist:**

- [X] ⚖️ My code follows the style guidelines of this project
- [X] 👀 I have performed a self-review of my own code
- [ ] #️⃣ I have commented my code, particularly in hard-to-understand
areas
- [ ] 📄 I have made corresponding changes to the documentation
- [ ] ⚠️ My changes generate no new warnings
- [ ] 🧪 I have added tests to this description that prove my fix is
effective or that my feature works
- [X] ⬆️ I increased versions for any altered app according to semantic
versioning

**➕ App addition**

If this PR is an app addition please make sure you have done the
following.

- [ ] 🪞 I have opened a PR on
[truecharts/containers](https://github.com/truecharts/containers) adding
the container to TrueCharts mirror repo.
- [ ] 🖼️ I have added an icon in the Chart's root directory called
`icon.png`

---

_Please don't blindly check all the boxes. Read them and only check
those that apply.
Those checkboxes are there for the reviewer to see what is this all
about and
the status of this PR with a quick glance._

charts/stable/livestreamdvr/Chart.yaml

@@ -1,15 +1,15 @@
 kubeVersion: ">=1.24.0-0"
 apiVersion: v2
 name: livestreamdvr
-version: 3.0.16
+version: 3.1.0
 appVersion: master
 description: An automatic twitch recorder.
-home: https://truecharts.org/charts/incubator/livestreamdvr
+home: https://truecharts.org/charts/stable/livestreamdvr
 icon: https://truecharts.org/img/hotlink-ok/chart-icons/livestreamdvr.png
 deprecated: false
 sources:
   - https://github.com/MrBrax/LiveStreamDVR
-  - https://github.com/truecharts/charts/tree/master/charts/incubator/livestreamdvr
+  - https://github.com/truecharts/charts/tree/master/charts/stable/livestreamdvr
   - https://hub.docker.com/r/mrbrax/twitchautomator
 maintainers:
   - name: TrueCharts
@@ -33,5 +33,5 @@ annotations:
   truecharts.org/category: MediaApp-Video
   truecharts.org/max_helm_version: "3.13"
   truecharts.org/min_helm_version: "3.12"
-  truecharts.org/train: incubator
+  truecharts.org/train: stable
 type: application

charts/stable/livestreamdvr/questions.yaml

@@ -17,17 +17,24 @@ questions:
                                     additional_attrs: true
                                     type: dict
                                     attrs:
-                                      - variable: UMASK
-                                        label: "UMASK"
-                                        schema:
-                                          type: string
-                                          default: "022"
                                       - variable: TCD_ENABLE_FILES_API
-                                        label: "TCD_ENABLE_FILES_API"
+                                        label: "TCD Enable Files API"
-                                        description: "May enable exploits."
+                                        description: "Enable the files api, making it possible to download and delete files in storage. This might open up filesystem exploits."
                                         schema:
-                                          type: string
+                                          type: boolean
-                                          default: "0"
+                                          default: false
+                                      - variable: TCD_EXPOSE_LOGS_TO_PUBLIC
+                                        label: "TCD Expose Logs To Public"
+                                        description: "Make viewing logs in the file manager possible. Requires the above environment variable to be set."
+                                        schema:
+                                          type: boolean
+                                          default: false
+                                      - variable: TCD_MIGRATE_OLD_VOD_JSON
+                                        label: "TCD Migrate Old VOD JSON"
+                                        description: "Migrate old vod json files to the new format."
+                                        schema:
+                                          type: boolean
+                                          default: false
 # Include{serviceRoot}
         - variable: main
           label: "Main Service"
@@ -55,29 +62,33 @@ questions:
 # Include{serviceExpert}
 # Include{serviceList}
 # Include{persistenceRoot}
-        - variable: hostpath1
-          label: "hostpath1 Storage"
-          schema:
-            additional_attrs: true
-            type: dict
-            attrs:
-# Include{persistenceBasic}
-        - variable: hostpath2
-          label: "hostpath2 Storage"
-          schema:
-            additional_attrs: true
-            type: dict
-            attrs:
-# Include{persistenceBasic}
         - variable: config
-          label: "config Storage"
+          label: App Config Storage
+          description: Stores the Application Config.
           schema:
             additional_attrs: true
             type: dict
             attrs:
 # Include{persistenceBasic}
-        - variable: hostpath4
+        - variable: cache
-          label: "hostpath4 Storage"
+          label: App Cache Storage
+          description: Stores the Application Cache.
+          schema:
+            additional_attrs: true
+            type: dict
+            attrs:
+# Include{persistenceBasic}
+        - variable: logs
+          label: App Logs Storage
+          description: Stores the Application Logs.
+          schema:
+            additional_attrs: true
+            type: dict
+            attrs:
+# Include{persistenceBasic}
+        - variable: storage
+          label: App Storage Storage
+          description: Stores the Application Storage.
           schema:
             additional_attrs: true
             type: dict

charts/stable/livestreamdvr/values.yaml

@@ -2,38 +2,47 @@ image:
   pullPolicy: IfNotPresent
   repository: mrbrax/twitchautomator
   tag: master@sha256:8a93df9a76735e3484639c103c2e7609f6a66e907dd18199fcf7ebd0f635626d
-persistence:
+
-  config:
-    enabled: true
-    mountPath: /usr/local/share/twitchautomator/data/config
-  hostpath1:
-    enabled: true
-    mountPath: /usr/local/share/twitchautomator/data/storage
-  hostpath2:
-    enabled: true
-    mountPath: /usr/local/share/twitchautomator/data/cache
-  hostpath4:
-    enabled: true
-    mountPath: /usr/local/share/twitchautomator/data/logs
-portal:
-  open:
-    enabled: true
 securityContext:
   container:
     readOnlyRootFilesystem: false
     runAsGroup: 0
     runAsUser: 0
+
 service:
   main:
     ports:
       main:
+        protocol: http
         port: 8146
-        protocol: tcp
+
-        targetPort: 8080
 workload:
   main:
     podSpec:
       containers:
         main:
+          args:
+            - --port
+            - "{{ .Values.service.main.ports.main.port }}"
           env:
-            TCD_ENABLE_FILES_API: "0"
+            TCD_ENABLE_FILES_API: false
+            TCD_EXPOSE_LOGS_TO_PUBLIC: false
+            TCD_MIGRATE_OLD_VOD_JSON: false
+
+persistence:
+  config:
+    enabled: true
+    mountPath: /usr/local/share/twitchautomator/data/config
+  cache:
+    enabled: true
+    mountPath: /usr/local/share/twitchautomator/data/cache
+  logs:
+    enabled: true
+    mountPath: /usr/local/share/twitchautomator/data/logs
+  storage:
+    enabled: true
+    mountPath: /usr/local/share/twitchautomator/data/storage
+
+portal:
+  open:
+    enabled: true