fix(plex): fix probe protocol->scheme (#8616)

**Description**
<!--
Please include a summary of the change and which issue is fixed. Please
also include relevant motivation and context. List any dependencies that
are required for this change.
-->
⚒️ Fixes  # <!--(issue)-->

**⚙️ Type of change**

- [ ] ⚙️ Feature/App addition
- [x] 🪛 Bugfix
- [ ] ⚠️ Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] 🔃 Refactor of current code

**🧪 How Has This Been Tested?**
<!--
Please describe the tests that you ran to verify your changes. Provide
instructions so we can reproduce. Please also list any relevant details
for your test configuration
-->

**📃 Notes:**
<!-- Please enter any other relevant information here -->

**✔️ Checklist:**

- [x] ⚖️ My code follows the style guidelines of this project
- [x] 👀 I have performed a self-review of my own code
- [ ] #️⃣ I have commented my code, particularly in hard-to-understand
areas
- [ ] 📄 I have made corresponding changes to the documentation
- [x] ⚠️ My changes generate no new warnings
- [ ] 🧪 I have added tests to this description that prove my fix is
effective or that my feature works
- [x] ⬆️ I increased versions for any altered app according to semantic
versioning

** App addition**

If this PR is an app addition please make sure you have done the
following.

- [ ] 🪞 I have opened a PR on
[truecharts/containers](https://github.com/truecharts/containers) adding
the container to TrueCharts mirror repo.
- [ ] 🖼️ I have added an icon in the Chart's root directory called
`icon.png`

---

_Please don't blindly check all the boxes. Read them and only check
those that apply.
Those checkboxes are there for the reviewer to see what is this all
about and
the status of this PR with a quick glance._
This commit is contained in:
Stavros Kois 2023-04-30 17:46:40 +03:00 committed by GitHub
parent 93ca2988b3
commit edc2dd1cdd
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
6 changed files with 13 additions and 13 deletions

View File

@ -21,7 +21,7 @@ sources:
- https://github.com/truecharts/charts/tree/master/charts/stable/plex - https://github.com/truecharts/charts/tree/master/charts/stable/plex
- https://github.com/k8s-at-home/container-images/pkgs/container/plex - https://github.com/k8s-at-home/container-images/pkgs/container/plex
type: application type: application
version: 13.0.12 version: 13.0.13
annotations: annotations:
truecharts.org/catagories: | truecharts.org/catagories: |
- media - media

View File

@ -1,2 +0,0 @@
plex:
requireHTTPS: true

View File

@ -61,10 +61,14 @@ questions:
default: true default: true
- variable: requireHTTPS - variable: requireHTTPS
label: Require HTTPS label: Require HTTPS
description: Please use this toggle to "Require HTTPS", do not use the Plex UI. description: |
NOTE: Only enable this setting AFTER you are done with the initial configuration
of your Plex Server and verify that remote access is working.</br>
Please use this toggle to "Require HTTPS", instead of using the Plex UI,
so probes are configured correctly.
schema: schema:
type: boolean type: boolean
default: true default: false
# Include{containerConfig} # Include{containerConfig}
# Include{podOptions} # Include{podOptions}

View File

@ -8,9 +8,10 @@
{{- $protocol = "https" -}} {{- $protocol = "https" -}}
{{- end -}} {{- end -}}
{{- $_ := set .Values.workload.main.podSpec.containers.main.probes.liveness "protocol" $protocol -}} {{- $_ := set .Values.workload.main.podSpec.containers.main.probes.liveness "scheme" $protocol -}}
{{- $_ := set .Values.workload.main.podSpec.containers.main.probes.readiness "protocol" $protocol -}} {{- $_ := set .Values.workload.main.podSpec.containers.main.probes.readiness "scheme" $protocol -}}
{{- $_ := set .Values.workload.main.podSpec.containers.main.probes.startup "protocol" $protocol -}} {{- $_ := set .Values.workload.main.podSpec.containers.main.probes.startup "scheme" $protocol -}}
{{- $_ := set .Values.service.main.ports.main "protocol" $protocol -}}
{{- if not (eq .Values.service.main.type "ClusterIP") -}} {{- if not (eq .Values.service.main.type "ClusterIP") -}}
{{- $serverURL = (printf "%v://%v:%v" $protocol .Values.plex.serverIP .Values.service.main.ports.main.port) -}} {{- $serverURL = (printf "%v://%v:%v" $protocol .Values.plex.serverIP .Values.service.main.ports.main.port) -}}

View File

@ -1,7 +1,7 @@
image: image:
repository: tccr.io/truecharts/plex repository: tccr.io/truecharts/plex
pullPolicy: IfNotPresent pullPolicy: IfNotPresent
tag: 1.31.3.6868@sha256:15a438c7e741a3158a04be54916dbb56be7bbe78129519b2fd91b285567029e3 tag: v1.32.0.6973@sha256:25f3e489457a7351bb25badba6b288b8c6b68c67ff973f6ff792010d7ecae110
service: service:
main: main:
ports: ports:
@ -20,7 +20,7 @@ plex:
serverIP: "127.0.0.1" serverIP: "127.0.0.1"
additionalAdvertiseURL: "" additionalAdvertiseURL: ""
disableGDM: true disableGDM: true
requireHTTPS: true requireHTTPS: false
workload: workload:
main: main:
@ -31,15 +31,12 @@ workload:
liveness: liveness:
enabled: true enabled: true
path: /identity path: /identity
protocol: http
readiness: readiness:
enabled: true enabled: true
path: /identity path: /identity
protocol: http
startup: startup:
enabled: true enabled: true
path: /identity path: /identity
protocol: http
env: env:
PLEX_PREFERENCE_GDM: 'GdmEnabled={{ ternary "0" "1" .Values.plex.disableGDM }}' PLEX_PREFERENCE_GDM: 'GdmEnabled={{ ternary "0" "1" .Values.plex.disableGDM }}'
# 0=Required, 1=Preferred # 0=Required, 1=Preferred