feat(minecraft-java) add wider packwiz support (#17523)
**Description** Updated minecraft-java's questions.yaml to allow downloading packwiz packs when modloaders other than Fabric are chosen. The developer of the docker image has [stated](https://github.com/itzg/docker-minecraft-server/issues/1238#issuecomment-1003560897) that packwiz support is not limited to Fabric. Mod loaders supported by packwiz itself are listed [here](https://packwiz.infra.link/reference/commands/packwiz/init/#options). **⚙️ Type of change** - [x] ⚙️ Feature/App addition - [ ] 🪛 Bugfix - [ ] ⚠️ Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] 🔃 Refactor of current code **🧪 How Has This Been Tested?** I don't have the capability to test this at this time. **📃 Notes:** I haven't worked on TrueNAS apps/questions.yaml before but based on my understanding from reading the docs this should be correct. If there is a way to combine all the added lines using a compound show-if statement (ie show-if type is forge or fabric or quilt or neoforge) I couldn't find documentation on it. **✔️ Checklist:** - [x] ⚖️ My code follows the style guidelines of this project - [ ] 👀 I have performed a self-review of my own code - [ ] #️⃣ I have commented my code, particularly in hard-to-understand areas - [ ] 📄 I have made corresponding changes to the documentation - [ ] ⚠️ My changes generate no new warnings - [ ] 🧪 I have added tests to this description that prove my fix is effective or that my feature works - [ ] ⬆️ I increased versions for any altered app according to semantic versioning --------- Signed-off-by: H <37481947+H-QueerCoded@users.noreply.github.com>
This commit is contained in:
parent
64a34242b2
commit
f65459a89b
|
@ -35,4 +35,4 @@ sources:
|
||||||
- https://hub.docker.com/r/itzg/minecraft-server
|
- https://hub.docker.com/r/itzg/minecraft-server
|
||||||
- https://hub.docker.com/r/itzg/mc-backup
|
- https://hub.docker.com/r/itzg/mc-backup
|
||||||
type: application
|
type: application
|
||||||
version: 7.1.11
|
version: 7.1.12
|
||||||
|
|
|
@ -126,6 +126,12 @@ questions:
|
||||||
description: Pufferfish
|
description: Pufferfish
|
||||||
- value: CUSTOM
|
- value: CUSTOM
|
||||||
description: Custom
|
description: Custom
|
||||||
|
- variable: PACKWIZ_URL
|
||||||
|
label: Packwiz URL
|
||||||
|
schema:
|
||||||
|
type: string
|
||||||
|
default: ""
|
||||||
|
show_if: [[TYPE, "!=", "VANILLA"]]
|
||||||
- variable: CUSTOM_SERVER
|
- variable: CUSTOM_SERVER
|
||||||
label: Custom Server
|
label: Custom Server
|
||||||
description: URL or a container path to an existing JAR file, will ONLY download once.
|
description: URL or a container path to an existing JAR file, will ONLY download once.
|
||||||
|
@ -208,12 +214,6 @@ questions:
|
||||||
type: string
|
type: string
|
||||||
default: ""
|
default: ""
|
||||||
show_if: [[TYPE, "=", "FABRIC"]]
|
show_if: [[TYPE, "=", "FABRIC"]]
|
||||||
- variable: PACKWIZ_URL
|
|
||||||
label: Packwiz URL
|
|
||||||
schema:
|
|
||||||
type: string
|
|
||||||
default: ""
|
|
||||||
show_if: [[TYPE, "=", "FABRIC"]]
|
|
||||||
- variable: SPIGOT_DOWNLOAD_URL
|
- variable: SPIGOT_DOWNLOAD_URL
|
||||||
label: Spigot Download URL
|
label: Spigot Download URL
|
||||||
schema:
|
schema:
|
||||||
|
|
|
@ -158,6 +158,7 @@ workload:
|
||||||
ONLINE_MODE: true
|
ONLINE_MODE: true
|
||||||
MEMORY: 2048M
|
MEMORY: 2048M
|
||||||
RCON_PASSWORD: "secretrconpass"
|
RCON_PASSWORD: "secretrconpass"
|
||||||
|
# PACKWIZ_URL: ""
|
||||||
# CUSTOM_SERVER: ""
|
# CUSTOM_SERVER: ""
|
||||||
# QUILT_LOADER_VERSION: ""
|
# QUILT_LOADER_VERSION: ""
|
||||||
# QUILT_LAUNCHER: ""
|
# QUILT_LAUNCHER: ""
|
||||||
|
@ -174,7 +175,6 @@ workload:
|
||||||
# BUKKIT_DOWNLOAD_URL: ""
|
# BUKKIT_DOWNLOAD_URL: ""
|
||||||
# PAPERBUILD: ""
|
# PAPERBUILD: ""
|
||||||
# PAPER_DOWNLOAD_URL: ""
|
# PAPER_DOWNLOAD_URL: ""
|
||||||
# PACKWIZ_URL: ""
|
|
||||||
# AIRPLANE_BUILD: "lastSuccessfulBuild"
|
# AIRPLANE_BUILD: "lastSuccessfulBuild"
|
||||||
# MAGMA_CHANNEL: "stable"
|
# MAGMA_CHANNEL: "stable"
|
||||||
# MOHIST_BUILD: ""
|
# MOHIST_BUILD: ""
|
||||||
|
|
Loading…
Reference in New Issue