fix(valheim): Correctly map ports when changed in the UI (#1921)

* fix(valheim): Correctly map ports when changed in the UI

* remove `-` from service name

* don't use tpl for targetPort

* tpl on `port`

* no tpl on port either

* remove targetPort and document reason

charts/games/valheim/Chart.yaml

@@ -18,7 +18,7 @@ name: valheim
 sources:
 - https://github.com/lloesche/valheim-server-docker
 - https://hub.docker.com/r/lloesche/valheim-server
-version: 2.0.23
+version: 2.0.24
 annotations:
   truecharts.org/catagories: |
     - media

charts/games/valheim/questions.yaml

@@ -297,7 +297,7 @@ questions:
             type: dict
             attrs:
 # Include{serviceSelector}
-                    - variable: valheim-1
+                    - variable: valheim1
                       label: "valheim-1 Service Port Configuration"
                       schema:
                         additional_attrs: true
@@ -345,7 +345,7 @@ questions:
                                     type: int
                                     default: 2456
 
-                    - variable: valheim-2
+                    - variable: valheim2
                       label: "valheim-2 Service Port Configuration"
                       schema:
                         additional_attrs: true
@@ -393,7 +393,7 @@ questions:
                                     type: int
                                     default: 2457
 
-                    - variable: valheim-3
+                    - variable: valheim3
                       label: "valheim-3 Service Port Configuration"
                       schema:
                         additional_attrs: true

charts/games/valheim/values.yaml

@@ -1,26 +1,21 @@
 image:
-  # -- image repository
   repository: tccr.io/truecharts/valheim-server
-  # -- image tag
   tag: latest@sha256:8f87fda54429923cac3601d581d6dc0ff273ef6438374e9f4b1e5ac1141b461d
-  # -- image pull policy
   pullPolicy: IfNotPresent
 
 secret:
   SUPERVISOR_HTTP_USER: admin
   SUPERVISOR_HTTP_PASS: secret
   SERVER_PASS: secret
-# -- environment variables. See [image docs](https://github.com/lloesche/valheim-server-docker#environment-variables) for more details.
-# @default -- See below
+
 env:
-  # -- Set the container timezone
   TZ: UTC
   STATUS_HTTP: true
-  STATUS_HTTP_PORT: 9010
-  SUPERVISOR_HTTP_PORT: 9011
+  STATUS_HTTP_PORT: "{{ .Values.service.main.ports.main.port }}"
+  SUPERVISOR_HTTP_PORT: "{{ .Values.service.supervisor.ports.supervisor.port }}"
   SUPERVISOR_HTTP: true
   SERVER_NAME: My Server
-  SERVER_PORT: 2456
+  SERVER_PORT: "{{ .Values.service.valheim.ports.valheim1.port }}"
   WORLD_NAME: Dedicated
   SERVER_PUBLIC: true
   UPDATE_INTERVAL: 10800
@@ -37,43 +32,34 @@ podSecurityContext:
   runAsUser: 0
   runAsGroup: 0
 
-# -- Configures service settings for the chart.
-# @default -- See values.yaml
 service:
   main:
     ports:
       main:
         port: 9010
-        targetPort: 9010
   supervisor:
     enabled: true
     ports:
       supervisor:
         enabled: true
         port: 9011
-        targetPort: 9011
   valheim:
     enabled: true
     type: LoadBalancer
     ports:
-      valheim-1:
+      valheim1:
         enabled: true
         port: 2456
-        targetPort: 2456
         protocol: UDP
-      valheim-2:
+      valheim2:
         enabled: true
         port: 2457
-        targetPort: 2457
         protocol: UDP
-      valheim-3:
+      valheim3:
         enabled: true
         port: 2458
         protocol: UDP
-        targetPort: 2458
 
-# -- Configure persistence settings for the chart under this key.
-# @default -- See values.yaml
 persistence:
   config:
     enabled: true

docs/apps/games/valheim/notes.md

@@ -0,0 +1,8 @@
+# Installation Notes
+
+Valheim app does not support having different port numbers for `port` and `targetPort`.
+Setting `port` will set the same port number to `targetPort` and it's Environmental Variable.
+e.g `STATUS_HTTP_PORT`, `SUPERVISOR_HTTP_PORT`, `SERVER_PORT`
+
+Also, services named `valheim1`, `valheim2`, `valheim3`, should be continuous port numbers. eg 2456, 2457, 2458.
+You can't skip a number!