Common 4.0 App Refactor Part 3 - Ornias

.github/workflows/apps.yaml

@@ -156,6 +156,18 @@ jobs:
         with:
           test-results: test.json
 
+      - name: Run tests
+        if: ${{ steps.prep-lint.outputs.unittests == 'true' }}
+        run: |
+         if grep -q "FAIL"  test.json
+         then
+            echo "Unit Test reported FAILED";
+            exit 1
+         else
+            echo "Unit Test reported OK";
+            exit 0
+         fi
+
 
     ##
     # Chart-Testing Section

charts/deprecated/nzbhydra/Chart.yaml

@@ -20,7 +20,7 @@ sources:
 dependencies:
   - name: common
     repository: https://truecharts.org/
-    version: 4.1.1
+    version: 4.1.2
     # condition:
 maintainers: []
 # annotations:

charts/incubator/appdaemon/Chart.yaml

@@ -16,7 +16,7 @@ sources:
 dependencies:
   - name: common
     repository: https://truecharts.org/
-    version: 4.1.1
+    version: 4.1.2
 maintainers:
   - name: TrueCharts
     email: info@truecharts.org

charts/incubator/bazarr/Chart.yaml

@@ -24,7 +24,7 @@ sources:
 dependencies:
   - name: common
     repository: https://truecharts.org/
-    version: 4.1.1
+    version: 4.1.2
     # condition:
 maintainers:
   - name: TrueCharts

charts/incubator/calibre-web/Chart.yaml

@@ -21,7 +21,7 @@ sources:
 dependencies:
   - name: common
     repository: https://truecharts.org/
-    version: 4.1.1
+    version: 4.1.2
     # condition:
 maintainers:
   - name: TrueCharts

charts/incubator/deluge/Chart.yaml

@@ -19,7 +19,7 @@ sources:
 dependencies:
   - name: common
     repository: https://truecharts.org/
-    version: 4.1.1
+    version: 4.1.2
     # condition:
 maintainers:
   - name: TrueCharts

charts/incubator/fireflyiii/Chart.yaml

@@ -16,7 +16,7 @@ sources:
 dependencies:
   - name: common
     repository: https://truecharts.org/
-    version: 4.1.1
+    version: 4.1.2
   - name: postgresql
     version: 10.4.3
     repository: https://charts.bitnami.com/bitnami

charts/incubator/freshrss/Chart.yaml

@@ -20,7 +20,7 @@ sources:
 dependencies:
   - name: common
     repository: https://truecharts.org/
-    version: 4.1.1
+    version: 4.1.2
     # condition:
 maintainers:
   - name: TrueCharts

charts/incubator/gaps/Chart.yaml

@@ -20,7 +20,7 @@ sources:
 dependencies:
   - name: common
     repository: https://truecharts.org/
-    version: 4.1.1
+    version: 4.1.2
     # condition:
 maintainers:
   - name: TrueCharts

charts/incubator/grocy/Chart.yaml

@@ -18,7 +18,7 @@ sources:
 dependencies:
   - name: common
     repository: https://truecharts.org/
-    version: 4.1.1
+    version: 4.1.2
     # condition:
 maintainers:
   - name: TrueCharts

charts/incubator/heimdall/Chart.yaml

@@ -17,7 +17,7 @@ sources:
 dependencies:
   - name: common
     repository: https://truecharts.org/
-    version: 4.1.1
+    version: 4.1.2
     # condition:
 maintainers:
   - name: TrueCharts

charts/incubator/lazylibrarian/Chart.yaml

@@ -20,7 +20,7 @@ sources:
 dependencies:
   - name: common
     repository: https://truecharts.org/
-    version: 4.1.1
+    version: 4.1.2
     # condition:
 maintainers:
   - name: TrueCharts

charts/incubator/lychee/Chart.yaml

@@ -21,7 +21,7 @@ sources:
 dependencies:
   - name: common
     repository: https://truecharts.org/
-    version: 4.1.1
+    version: 4.1.2
     # condition:
 maintainers:
   - name: TrueCharts

charts/incubator/navidrome/Chart.yaml

@@ -21,7 +21,7 @@ sources:
 dependencies:
   - name: common
     repository: https://truecharts.org/
-    version: 4.1.1
+    version: 4.1.2
     # condition:
 maintainers:
   - name: TrueCharts

charts/incubator/node-red/Chart.yaml

@@ -19,7 +19,7 @@ sources:
 dependencies:
   - name: common
     repository: https://truecharts.org/
-    version: 4.1.1
+    version: 4.1.2
     # condition:
 maintainers:
   - name: TrueCharts

charts/incubator/nzbget/Chart.yaml

@@ -20,7 +20,7 @@ sources:
 dependencies:
   - name: common
     repository: https://truecharts.org/
-    version: 4.1.1
+    version: 4.1.2
     # condition:
 maintainers:
   - name: TrueCharts

charts/incubator/organizr/Chart.yaml

@@ -19,7 +19,7 @@ sources:
 dependencies:
   - name: common
     repository: https://truecharts.org/
-    version: 4.1.1
+    version: 4.1.2
     # condition:
 maintainers:
   - name: TrueCharts

charts/incubator/podgrab/Chart.yaml

@@ -17,7 +17,7 @@ sources:
 dependencies:
   - name: common
     repository: https://truecharts.org/
-    version: 4.1.1
+    version: 4.1.2
 maintainers:
   - name: TrueCharts
     email: info@truecharts.org

charts/incubator/qbittorrent/Chart.yaml

@@ -19,7 +19,7 @@ sources:
 dependencies:
   - name: common
     repository: https://truecharts.org/
-    version: 4.1.1
+    version: 4.1.2
     # condition:
 maintainers:
   - name: TrueCharts

charts/incubator/readarr/Chart.yaml

@@ -23,7 +23,7 @@ sources:
 dependencies:
   - name: common
     repository: https://truecharts.org/
-    version: 4.1.1
+    version: 4.1.2
     # condition:
 maintainers:
   - name: TrueCharts

charts/incubator/sabnzbd/Chart.yaml

@@ -20,7 +20,7 @@ sources:
 dependencies:
   - name: common
     repository: https://truecharts.org/
-    version: 4.1.1
+    version: 4.1.2
     # condition:
 maintainers:
   - name: TrueCharts

charts/incubator/tvheadend/Chart.yaml

@@ -21,7 +21,7 @@ sources:
 dependencies:
   - name: common
     repository: https://truecharts.org/
-    version: 4.1.1
+    version: 4.1.2
     # condition:
 maintainers:
   - name: TrueCharts

charts/incubator/unifi/Chart.yaml

@@ -19,7 +19,7 @@ sources:
 dependencies:
   - name: common
     repository: https://truecharts.org/
-    version: 4.1.1
+    version: 4.1.2
     # condition:
 maintainers:
   - name: TrueCharts

charts/library/common-test/Chart.yaml

@@ -1,7 +1,7 @@
 apiVersion: v2
 kubeVersion: ">=1.16.0-0"
 name: common-test
-version: 3.0.0
+version: 3.0.1
 # upstream_version:
 appVersion: none
 description: Helper chart to test different use cases of the common library

charts/library/common-test/ci/basic-values.yaml

@@ -0,0 +1,22 @@
+image:
+  repository: b4bz/homer
+  tag: latest
+  pullPolicy: IfNotPresent
+
+service:
+  main:
+    ports:
+      main:
+        port: 8080
+
+ingress:
+  main:
+    enabled: true
+
+probes:
+  liveness:
+    enabled: true
+  readiness:
+    enabled: true
+  startup:
+    enabled: true

charts/library/common-test/values.yaml

@@ -2,9 +2,3 @@ image:
   repository: b4bz/homer
   tag: latest
   pullPolicy: IfNotPresent
-
-service:
-  main:
-    ports:
-      main:
-        port: 8080

charts/library/common/values.yaml

@@ -236,7 +236,7 @@ service:
         # -- Port protocol.
         # Support values are `HTTP`, `HTTPS`, `TCP` and `UDP`.
         # HTTPS and HTTPS spawn a TCP service and get used for internal URL and name generation
-          protocol: HTTP
+        protocol: HTTP
 
         # -- Specify a service targetPort if you wish to differ the service port from the application port.
         # If `targetPort` is specified, this port number is used in the container definition instead of

charts/stable/bitwarden/Chart.yaml

@@ -22,7 +22,7 @@ sources:
 dependencies:
   - name: common
     repository: https://truecharts.org/
-    version: 4.1.1
+    version: 4.1.2
     # condition:
   - name: postgresql
     version: 10.4.3

charts/stable/bitwarden/templates/_secrets.tpl

@@ -15,6 +15,7 @@
 {{- if eq .Values.bitwardenrs.yubico.enabled true }}
 {{- $yubicoClientId = required "Yubico Client ID required" .Values.bitwardenrs.yubico.clientId | toString | b64enc | quote }}
 {{- end -}}
+---
 
 apiVersion: v1
 kind: Secret

charts/stable/collabora-online/Chart.yaml

@@ -19,7 +19,7 @@ sources:
 dependencies:
   - name: common
     repository: https://truecharts.org/
-    version: 4.1.1
+    version: 4.1.2
     # condition:
 maintainers:
   - name: TrueCharts

charts/stable/deepstack-cpu/Chart.yaml

@@ -19,7 +19,7 @@ sources:
 dependencies:
   - name: common
     repository: https://truecharts.org/
-    version: 4.1.1
+    version: 4.1.2
     # condition:
 maintainers:
   - name: TrueCharts

charts/stable/emby/Chart.yaml

@@ -20,7 +20,7 @@ sources:
 dependencies:
   - name: common
     repository: https://truecharts.org/
-    version: 4.1.1
+    version: 4.1.2
     # condition:
 maintainers:
   - name: TrueCharts

charts/stable/esphome/Chart.yaml

@@ -19,7 +19,7 @@ sources:
 dependencies:
   - name: common
     repository: https://truecharts.org/
-    version: 4.1.1
+    version: 4.1.2
     # condition:
 maintainers:
   - name: TrueCharts

charts/stable/handbrake/Chart.yaml

@@ -21,7 +21,7 @@ sources:
 dependencies:
   - name: common
     repository: https://truecharts.org/
-    version: 4.1.1
+    version: 4.1.2
     # condition:
 maintainers:
   - name: TrueCharts

charts/stable/handbrake/values.yaml

@@ -6,14 +6,8 @@ image:
 strategy:
   type: Recreate
 
-startAsRoot: true
-
 # Configure the Security Context for the Pod
 podSecurityContext:
-  runAsNonRoot: false
-  runAsUser: 0
-  runAsGroup: 0
-  fsGroup: 0
   supplementalGroups: [24, 44, 107]
 
 service:

charts/stable/home-assistant/Chart.yaml

@@ -21,7 +21,7 @@ sources:
 dependencies:
   - name: common
     repository: https://truecharts.org/
-    version: 4.1.1
+    version: 4.1.2
     # condition:
   # ## postgresql is currently not ported to SCALE yet.
   # - name: postgresql

charts/stable/jackett/Chart.yaml

@@ -21,7 +21,7 @@ sources:
 dependencies:
   - name: common
     repository: https://truecharts.org/
-    version: 4.1.1
+    version: 4.1.2
     # condition:
 maintainers:
   - name: TrueCharts

charts/stable/jellyfin/Chart.yaml

@@ -21,7 +21,7 @@ sources:
 dependencies:
   - name: common
     repository: https://truecharts.org/
-    version: 4.1.1
+    version: 4.1.2
     # condition:
 maintainers:
   - name: TrueCharts

charts/stable/kms/Chart.yaml

@@ -17,7 +17,7 @@ sources:
 dependencies:
   - name: common
     repository: https://truecharts.org/
-    version: 4.1.1
+    version: 4.1.2
     # condition:
 maintainers:
   - name: TrueCharts

charts/stable/lidarr/Chart.yaml

@@ -21,7 +21,7 @@ sources:
 dependencies:
   - name: common
     repository: https://truecharts.org/
-    version: 4.1.1
+    version: 4.1.2
     # condition:
 maintainers:
   - name: TrueCharts

charts/stable/ombi/Chart.yaml

@@ -24,7 +24,7 @@ sources:
 dependencies:
   - name: common
     repository: https://truecharts.org/
-    version: 4.1.1
+    version: 4.1.2
     # condition:
 maintainers:
   - name: TrueCharts

charts/stable/plex/Chart.yaml

@@ -17,7 +17,7 @@ sources:
 dependencies:
   - name: common
     repository: https://truecharts.org/
-    version: 4.1.1
+    version: 4.1.2
     # condition:
 maintainers:
   - name: TrueCharts

charts/stable/radarr/Chart.yaml

@@ -21,7 +21,7 @@ sources:
 dependencies:
   - name: common
     repository: https://truecharts.org/
-    version: 4.1.1
+    version: 4.1.2
     # condition:
 maintainers:
   - name: TrueCharts

charts/stable/sonarr/Chart.yaml

@@ -21,7 +21,7 @@ sources:
 dependencies:
   - name: common
     repository: https://truecharts.org/
-    version: 4.1.1
+    version: 4.1.2
     # condition:
 maintainers:
   - name: TrueCharts

charts/stable/syncthing/Chart.yaml

@@ -18,7 +18,7 @@ sources:
 dependencies:
   - name: common
     repository: https://truecharts.org/
-    version: 4.1.1
+    version: 4.1.2
     # condition:
 maintainers:
   - name: TrueCharts

charts/stable/tautulli/Chart.yaml

@@ -20,7 +20,7 @@ sources:
 dependencies:
   - name: common
     repository: https://truecharts.org/
-    version: 4.1.1
+    version: 4.1.2
     # condition:
 maintainers:
   - name: TrueCharts

charts/stable/traefik/Chart.yaml

@@ -1,7 +1,7 @@
 apiVersion: v2
 kubeVersion: ">=1.16.0-0"
 name: traefik
-version: 4.0.0
+version: 3.2.4
 appVersion: "auto"
 description: A Traefik based Reverse Proxy and Certificate Manager
 type: application
@@ -19,7 +19,7 @@ sources:
 dependencies:
   - name: common
     repository: https://truecharts.org/
-    version: 4.1.1
+    version: 3.5.8
     # condition:
   - name: traefik
     repository: https://helm.traefik.io/traefik

charts/stable/traefik/SCALE/questions.yaml

@@ -6,15 +6,13 @@ groups:
   - name: "Configuration"
     description: "additional container configuration"
   - name: "Networking"
-    description: "Configure Network and Services for container"
+    description: "Configure / service for container"
   - name: "Storage"
     description: "Persist and share data that is separate from the lifecycle of the container"
   - name: "Resources and Devices"
     description: "Specify resources/devices to be allocated to workload"
-  - name: "Ingress Configuration"
+  - name: "Reverse Proxy Configuration"
-    description: "Ingress Configuration"
+    description: "Reverse Proxy configuration"
-  - name: "Security"
-    description: "Configure security context"
   - name: "Advanced"
     description: "Advanced Configuration"
   - name: "WARNING"
@@ -52,18 +50,103 @@ questions:
       default: "Etc/UTC"
       $ref:
         - "definitions/timezone"
-  - variable: env
+
-    group: "Configuration"
+  - variable: ingress
-    label: "Image Environment"
+    label: ""
+    group: "Reverse Proxy Configuration"
     schema:
       type: dict
       attrs:
-        - variable: UMASK
+        - variable: main
-          label: "UMASK"
+          label: "WebUI"
-          description: "Sets the UMASK env var for LinuxServer.io (compatible) containers"
           schema:
-            type: string
+            type: dict
-            default: "002"
+            attrs:
+              - variable: enabled
+                label: "Enable Web Reverse Proxy"
+                schema:
+                  type: boolean
+                  default: false
+                  show_subquestions_if: true
+                  subquestions:
+                    - variable: type
+                      label: "Reverse Proxy Type"
+                      schema:
+                        type: string
+                        default: "HTTP-IR"
+                        hidden: true
+                        editable: false
+                        required: true
+                    - variable: serviceName
+                      label: "Service name to proxy to"
+                      schema:
+                        hidden: true
+                        editable: false
+                        type: string
+                        default: "api@internal"
+                    - variable: serviceKind
+                      label: "Service Kind to proxy to"
+                      schema:
+                        hidden: true
+                        editable: false
+                        type: string
+                        default: "TraefikService"
+                    - variable: entrypoint
+                      label: "Select Entrypoint"
+                      schema:
+                        type: string
+                        default: "websecure"
+                        required: true
+                        enum:
+                          - value: "websecure"
+                            description: "Websecure: HTTPS/TLS port 443"
+                    - variable: hosts
+                      label: "Hosts"
+                      schema:
+                        type: list
+                        default: []
+                        items:
+                          - variable: host
+                            label: "Host"
+                            schema:
+                              type: dict
+                              attrs:
+                                - variable: host
+                                  label: "Domain Name"
+                                  required: true
+                                  schema:
+                                    type: string
+                                - variable: path
+                                  label: "path"
+                                  schema:
+                                    type: string
+                                    required: true
+                                    hidden: true
+                                    default: "/"
+                    - variable: certType
+                      label: "Select Certificate Type"
+                      schema:
+                        type: string
+                        default: "selfsigned"
+                        enum:
+                          - value: ""
+                            description: "No Encryption/TLS/Certificates"
+                          - value: "selfsigned"
+                            description: "Self-Signed Certificate"
+                          - value: "ixcert"
+                            description: "TrueNAS SCALE Certificate"
+                    - variable: certificate
+                      label: "Select TrueNAS SCALE Certificate"
+                      schema:
+                        type: int
+                        show_if: [["certType", "=", "ixcert"]]
+                        $ref:
+                          - "definitions/certificate"
+                    - variable: authForwardURL
+                      label: "Forward Authentication URL"
+                      schema:
+                        type: string
+                        default: ""
   - variable: traefik
     label: "(Advanced) Traefik Settings"
     group: "Advanced"
@@ -659,9 +742,17 @@ questions:
                 schema:
                   type: string
                   default: ""
+
+  - variable: UMASK
+    group: "Advanced"
+    label: "UMASK"
+    description: "Sets the UMASK env var for LinuxServer.io (compatible) containers"
+    schema:
+      type: string
+      default: "002"
   # Enable privileged
   - variable: securityContext
-    group: "Security"
+    group: "Advanced"
     label: "Security Context"
     schema:
       type: dict
@@ -673,7 +764,7 @@ questions:
             default: false
   # Set Pod Security Policy
   - variable: podSecurityContext
-    group: "Security"
+    group: "Advanced"
     label: "Pod Security Context"
     schema:
       type: dict
@@ -728,12 +819,12 @@ questions:
     description: "Please be sure to set the UI to a different port or adapter"
     group: "WARNING"
     schema:
-      type: dict
+        type: dict
-      attrs:
+        attrs:
-        - variable: confirm-warning
+          - variable: confirm-warning
-          description: "Check this to confirm you have made precautions against conflicts on port 80 and 443, such as running the TrueNAS SCALE UI on a different port or adapter."
+            description: "Check this to confirm you have made precautions against conflicts on port 80 and 443, such as running the TrueNAS SCALE UI on a different port or adapter."
-          label: "I understand above warning and its consequences"
+            label: "I understand above warning and its consequences"
-          schema:
+            schema:
-            type: boolean
+              type: boolean
-            default: false
+              default: false
-            required: true
+              required: true

charts/stable/traefik/values.yaml

@@ -260,7 +260,7 @@ ingress:
             # Ignored if not kubeVersion >= 1.14-0
             pathType: Prefix
 
-externalservice:
+externalServices:
   - enabled: true
     name: "test"
     type: "HTTP"

charts/stable/transmission/Chart.lock

@@ -1,6 +0,0 @@
-dependencies:
-- name: common
-  repository: https://truecharts.org/
-  version: 4.1.1
-digest: sha256:d13c8b723da27f049ec5a709db8128a96033773c1be13330a453daa4e4d0b7ff
-generated: "2021-05-20T18:13:40.3933879+02:00"

charts/stable/transmission/Chart.yaml

@@ -20,7 +20,7 @@ sources:
 dependencies:
   - name: common
     repository: https://truecharts.org/
-    version: 4.1.1
+    version: 4.1.2
     # condition:
 maintainers:
   - name: TrueCharts

charts/stable/truecommand/Chart.yaml

@@ -17,7 +17,7 @@ sources:
 dependencies:
   - name: common
     repository: https://truecharts.org/
-    version: 4.1.1
+    version: 4.1.2
     # condition:
 maintainers:
   - name: TrueCharts

charts/stable/zwavejs2mqtt/Chart.yaml

@@ -22,7 +22,7 @@ sources:
 dependencies:
   - name: common
     repository: https://truecharts.org/
-    version: 4.1.1
+    version: 4.1.2
     # condition:
 maintainers:
   - name: TrueCharts