**Description**
<!--
Please include a summary of the change and which issue is fixed. Please
also include relevant motivation and context. List any dependencies that
are required for this change.
-->
⚒️ Fixes # <!--(issue)-->
**⚙️ Type of change**
- [ ] ⚙️ Feature/App addition
- [ ] 🪛 Bugfix
- [ ] ⚠️ Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] 🔃 Refactor of current code
**🧪 How Has This Been Tested?**
<!--
Please describe the tests that you ran to verify your changes. Provide
instructions so we can reproduce. Please also list any relevant details
for your test configuration
-->
**📃 Notes:**
<!-- Please enter any other relevant information here -->
**✔️ Checklist:**
- [ ] ⚖️ My code follows the style guidelines of this project
- [ ] 👀 I have performed a self-review of my own code
- [ ] #️⃣ I have commented my code, particularly in hard-to-understand
areas
- [ ] 📄 I have made corresponding changes to the documentation
- [ ] ⚠️ My changes generate no new warnings
- [ ] 🧪 I have added tests to this description that prove my fix is
effective or that my feature works
- [ ] ⬆️ I increased versions for any altered app according to semantic
versioning
**➕ App addition**
If this PR is an app addition please make sure you have done the
following.
- [ ] 🪞 I have opened a PR on
[truecharts/containers](https://github.com/truecharts/containers) adding
the container to TrueCharts mirror repo.
- [ ] 🖼️ I have added an icon in the Chart's root directory called
`icon.png`
---
_Please don't blindly check all the boxes. Read them and only check
those that apply.
Those checkboxes are there for the reviewer to see what is this all
about and
the status of this PR with a quick glance._
The app-changelog.md files that are generated by git-chglog are not
being constrained tightly enough to specific branches to present useful
changelogs. For example, the plex-12.0.10..plex-12.0.11 changelog link
to GitHub points to the comparison between
plex-utills-3.0.9..plex-12.0.11.
Using -\d+\.\d+\.\d+ as the tag name suffix seems safe since the version
numbers are under this project's control.
Signed-off-by: Dan Christensen <opello@opello.org>
* style: Split long lines, follow .editorconfig
Signed-off-by: Dan Christensen <opello@opello.org>
* fix: Clarify why some sources are being excluded
The explanation is also meant to remind anyone that sees it that the
code could inadvertently remove a sources sequence entry that was
intentionally added, because it can not tell.
Signed-off-by: Dan Christensen <opello@opello.org>
* fix: Comment the image-to-URL code
Signed-off-by: Dan Christensen <opello@opello.org>
* refactor: Use case instead of if-ladder
This is a faithful move from the if-ladder to a case statement that
preserves the existing behavior, with optimization to follow. The
behavior of the function before and after this change is the same.
Signed-off-by: Dan Christensen <opello@opello.org>
* fix: Remove dead code
No "container source" entry from description_list.md has a scheme. The
values are parsed from the Dockerfiles and would not have one there
either.
Signed-off-by: Dan Christensen <opello@opello.org>
* fix: tccr.io image links
Parse the tccr.io prefix specifically instead of just checking for the
substring tccr which could result in a false positive.
The generated link was also going to point to a truecharts subdirectory
under mirror in the containers repository that does not exist.
Signed-off-by: Dan Christensen <opello@opello.org>
* fix: lscr.io image links
Parse the lscr.io prefix specifically instead of just checking for the
substring lscr which could result in a false positive.
The generated link would also return a 404 because the web interface
requires the image name to be passed in the query string.
Signed-off-by: Dan Christensen <opello@opello.org>
* fix: gcr.io image links
Parse the gcr.io prefix specifically instead of just checking for the
substring gcr which could result in a false positive.
Signed-off-by: Dan Christensen <opello@opello.org>
* feat: Do not add sources if no prefix is created
The intent of this code is to generate URLs to be included in
documentation to attribute inputs to the chart. If a publicly
accessible URL can not be generated from the image name it makes sense
to not add anything and instead rely on a manual edit to the Chart.yaml.
Signed-off-by: Dan Christensen <opello@opello.org>
* fix: Disable azurecr.io image links
There does not seem to be a general purpose web index to the azurecr.io
hosted images.
Signed-off-by: Dan Christensen <opello@opello.org>
* feat: Disable mcr.microsoft.com image links
Signed-off-by: Dan Christensen <opello@opello.org>
* fix: public.ecr.aws image links
Parse the public.ecr.aws prefix specifically instead of just checking
for the substring public.ecr.aws which could result in a false positive.
Signed-off-by: Dan Christensen <opello@opello.org>
* fix: Disable ocir.io image links
There does not seem to be a general purpose web index to the ocir.io
hosted images.
Signed-off-by: Dan Christensen <opello@opello.org>
* refactor: Add Docker Hub hosted image links
From the perspective of linking to image details on the Docker Hub web
interface, there are two types of images:
1. Docker Official Images
2. all of the other images, regardless of their trustworthiness
The Docker Official Images can be referenced several ways, either on the
command line when passed to docker pull, or in the FROM instruction of a
Dockerfile:
* busybox
* library/busybox
* docker.io/busybox
* docker.io/library/busybox
Furthermore, over the years there have been several domains used for the
official Docker Hub registry:
* docker.io
* index.docker.io
* registry-1.docker.io
* registry.hub.docker.com
The goal here is handling each possible case, which makes Docker Hub
images more complex than the handling for other registries.
It also makes the case block's '*' (default) case harder to find in the
sequence of glob expressions, but this is necessary to avoid repeating
the parsing or adding another helper function.
Reference:
https://github.com/docker/hub-feedback/issues/2113https://github.com/docker/cli/issues/3793
Signed-off-by: Dan Christensen <opello@opello.org>
* feat: ghcr.io image links
Signed-off-by: Dan Christensen <opello@opello.org>
* feat: quay.io image links
Signed-off-by: Dan Christensen <opello@opello.org>
* feat: Do not generate likely-bad links
By assuming image names that are not handled by other cases are Docker
Hub images there is a risk of generating bad links. Minimize this risk
by not generating a link if the image name for a Docker Hub link has two
slashes. This is a case that should not happen and would likely mean an
unsupported registry is being used.
There is still a risk of an unsupported registry being treated as Docker
Hub and an invalid link being generated. That case is if the domain and
image name is example.com/busybox where there is only one slash.
Signed-off-by: Dan Christensen <opello@opello.org>
* refactor: Sort cases
Sort the cases from longest to shortest prioritizing any case with a
suffix only glob over any case with a prefix glob. The intention is to
avoid having a case that can not be reached.
The combined Docker Hub and default case is last. It might make sense
to split the default case handling off but it does not seem to be a
problem right now.
Signed-off-by: Dan Christensen <opello@opello.org>
---------
Signed-off-by: Dan Christensen <opello@opello.org>
* fix(ci): Do not duplicate sources
Signed-off-by: Dan Christensen <opello@opello.org>
* fix(ci): Match chart against Markdown link text
More specifically match the chart to the container in the website's
description_list.md. Since multiple charts contain the term "plex" and
not all of them are even Plex related, extraneous sources were being put
in the plex Chart.yaml.
Signed-off-by: Dan Christensen <opello@opello.org>
---------
Signed-off-by: Dan Christensen <opello@opello.org>
StevenMcElligott