**Description**
<!--
Please include a summary of the change and which issue is fixed. Please
also include relevant motivation and context. List any dependencies that
are required for this change.
-->
⚒️ Fixes # <!--(issue)-->
**⚙️ Type of change**
- [ ] ⚙️ Feature/App addition
- [ ] 🪛 Bugfix
- [ ] ⚠️ Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] 🔃 Refactor of current code
**🧪 How Has This Been Tested?**
<!--
Please describe the tests that you ran to verify your changes. Provide
instructions so we can reproduce. Please also list any relevant details
for your test configuration
-->
**📃 Notes:**
<!-- Please enter any other relevant information here -->
**✔️ Checklist:**
- [ ] ⚖️ My code follows the style guidelines of this project
- [ ] 👀 I have performed a self-review of my own code
- [ ] #️⃣ I have commented my code, particularly in hard-to-understand
areas
- [ ] 📄 I have made corresponding changes to the documentation
- [ ] ⚠️ My changes generate no new warnings
- [ ] 🧪 I have added tests to this description that prove my fix is
effective or that my feature works
- [ ] ⬆️ I increased versions for any altered app according to semantic
versioning
**➕ App addition**
If this PR is an app addition please make sure you have done the
following.
- [ ] 🪞 I have opened a PR on
[truecharts/containers](https://github.com/truecharts/containers) adding
the container to TrueCharts mirror repo.
- [ ] 🖼️ I have added an icon in the Chart's root directory called
`icon.png`
---
_Please don't blindly check all the boxes. Read them and only check
those that apply.
Those checkboxes are there for the reviewer to see what is this all
about and
the status of this PR with a quick glance._
**Description**
The `ingressclassname` `entrypoint` and `tls` sections should only be
used in very specific usecases.
IngressClass: Only when having multiple ingress providers
Entrypoint: only when having multiple traefik entrypoints
tls: only when not using the clusterissuer setting on ingresslevel or
using scale certs which are deprecated.
fixes: #9142
**⚙️ Type of change**
- [x] ⚙️ Feature/App addition
- [ ] 🪛 Bugfix
- [x] ⚠️ Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [x] 🔃 Refactor of current code
**🧪 How Has This Been Tested?**
<!--
Please describe the tests that you ran to verify your changes. Provide
instructions so we can reproduce. Please also list any relevant details
for your test configuration
-->
**📃 Notes:**
<!-- Please enter any other relevant information here -->
**✔️ Checklist:**
- [ ] ⚖️ My code follows the style guidelines of this project
- [ ] 👀 I have performed a self-review of my own code
- [ ] #️⃣ I have commented my code, particularly in hard-to-understand
areas
- [ ] 📄 I have made corresponding changes to the documentation
- [ ] ⚠️ My changes generate no new warnings
- [ ] 🧪 I have added tests to this description that prove my fix is
effective or that my feature works
- [ ] ⬆️ I increased versions for any altered app according to semantic
versioning
**➕ App addition**
If this PR is an app addition please make sure you have done the
following.
- [ ] 🪞 I have opened a PR on
[truecharts/containers](https://github.com/truecharts/containers) adding
the container to TrueCharts mirror repo.
- [ ] 🖼️ I have added an icon in the Chart's root directory called
`icon.png`
---
_Please don't blindly check all the boxes. Read them and only check
those that apply.
Those checkboxes are there for the reviewer to see what is this all
about and
the status of this PR with a quick glance._
**Description**
Figured I'll manually add them to the initial batch of ported charts to
the new common that are missing the option
⚒️ Fixes # <!--(issue)-->
**⚙️ Type of change**
- [X] ⚙️ Feature/App addition
- [ ] 🪛 Bugfix
- [ ] ⚠️ Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] 🔃 Refactor of current code
**🧪 How Has This Been Tested?**
<!--
Please describe the tests that you ran to verify your changes. Provide
instructions so we can reproduce. Please also list any relevant details
for your test configuration
-->
**📃 Notes:**
<!-- Please enter any other relevant information here -->
**✔️ Checklist:**
- [X] ⚖️ My code follows the style guidelines of this project
- [ ] 👀 I have performed a self-review of my own code
- [ ] #️⃣ I have commented my code, particularly in hard-to-understand
areas
- [ ] 📄 I have made corresponding changes to the documentation
- [ ] ⚠️ My changes generate no new warnings
- [ ] 🧪 I have added tests to this description that prove my fix is
effective or that my feature works
- [X] ⬆️ I increased versions for any altered app according to semantic
versioning
**➕ App addition**
If this PR is an app addition please make sure you have done the
following.
- [ ] 🪞 I have opened a PR on
[truecharts/containers](https://github.com/truecharts/containers) adding
the container to TrueCharts mirror repo.
- [ ] 🖼️ I have added an icon in the Chart's root directory called
`icon.png`
---
_Please don't blindly check all the boxes. Read them and only check
those that apply.
Those checkboxes are there for the reviewer to see what is this all
about and
the status of this PR with a quick glance._
---------
Signed-off-by: StevenMcElligott <89483932+StevenMcElligott@users.noreply.github.com>
Signed-off-by: Kjeld Schouten <kjeld@schouten-lebbing.nl>
Co-authored-by: Kjeld Schouten <kjeld@schouten-lebbing.nl>
**Description**
Part 1 of the migration to new common on the stable train.
This basically breaks most/all charts requiring a reinstall on SCALE as
well.
Helm users shouldn't need a reinstall but could migrate their
values.yaml modification manually besides backing-up and porting the
databases.
There be Dragons basically, as we obviously cannot 100% go over
each-and-every single app in the stable train like we did in the
enterprise train.
**⚙️ Type of change**
- [x] ⚙️ Feature/App addition
- [x] 🪛 Bugfix
- [x] ⚠️ Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [x] 🔃 Refactor of current code
**🧪 How Has This Been Tested?**
Via CI and manually validation in a lot of cases where the CI did not
correctly check things.
Additional catalog item creation tooling for local testing has been
added as well.
**📃 Notes:**
There will be issues in the future but we should get as much working
well as we can.
**✔️ Checklist:**
- [x] ⚖️ My code follows the style guidelines of this project
- [x] 👀 I have performed a self-review of my own code
- [x] #️⃣ I have commented my code, particularly in hard-to-understand
areas
- [x] 📄 I have made corresponding changes to the documentation
- [x] ⚠️ My changes generate no new warnings
- [x] 🧪 I have added tests to this description that prove my fix is
effective or that my feature works
- [x] ⬆️ I increased versions for any altered app according to semantic
versioning
**➕ App addition**
If this PR is an app addition please make sure you have done the
following.
- [ ] 🪞 I have opened a PR on
[truecharts/containers](https://github.com/truecharts/containers) adding
the container to TrueCharts mirror repo.
- [ ] 🖼️ I have added an icon in the Chart's root directory called
`icon.png`
---
_Please don't blindly check all the boxes. Read them and only check
those that apply.
Those checkboxes are there for the reviewer to see what is this all
about and
the status of this PR with a quick glance._
* chore(questions): replace port parts with templates
* chore(questions): replace controller parts with templates
* remove tons of whitespce
* remove quotes from strings on templates
* make complete controller an include
* default to recreate
* remove replica and strategies as it's covered from controllerStrtegies include
* remove whitespace again
* replace controllertype with include (deployment/daemonset/statefulset)
* replace advanced port part except targetport
* remove more quotes
* add hidden toggle of enable the port
* new includes
* update build script
* controller deploy/stateful/deamon template changes
* replace controllerStrategies with replicas, replica#, strategy, recreate
* move 2 templates into a subfolder
* remove quotes
* remove disabled portals from questions and defined them on values
* remove enabled portal from the questions and add it on values
* one more app
* Portal cleanup
* remove portal templates
* add more includes
* replace portal links
* move some templates in folders
* replace ingressRoot with template
* more grouping
* replace persistenceroot with template
* replace serviceExpertRoot
* replace serviceroot
* fix a rogue one
* vctRoot
* securityContext cleanup
* remove quotes from templates on string
* replace vctRoot
* replace advanedSecurityRoot
* replace podsecurity root
* Update .github/scripts/build-catalog.sh
* Update values.yaml
* remove dupe portal
* update build-release script
* fix paths
* fix apps with imageSelector
Co-authored-by: Kjeld Schouten-Lebbing <kjeld@schouten-lebbing.nl>
* set TZ, PUID and UMASK differently
* more fixes
* this might be breaking so bump major
* ensure PUID and UMASK references are updated
* update test
* fiz references
* fix(apps): move conflicting ports to 10xxx range
* remove `protocol: TCP` as its the default anyway
* Change `"HTTP"` -> `HTTP` to much common
* lms udp port should be udp protocol
* resolve some conflicts
* clear port 80 conficts
* clean 3000 and 5000 port conflicts
* more conflict cleaning
* more conflict cleaning
* more cleanup
* more
* cleanup
* Avoid confclicts with official apps
* chore(apps): remove persistence size from values
* remove type from persistence from values.yaml
* remove accessMode from persistence from values
* devices dont user persistence
* remove empty lines
* restore accessMode in common, whoops
* quote all mountPaths
* convert `'` to `"`
* fix empty lines
* add missing mountPath on values
* add missing persistence on values
* fix var name on quetsions
* remove disabled persistence from values which are not even defined in questions
* remove more type, accessMode and size
* mountpath -> mountPath
* mounthPath -> mountPath
* booksonic-air persistence cleanup
* remove empty lines
* fix mountPath
* remove unused persistence
* teamspeak3 fix var name in persistence
* remove persistence that will probably be user defined storage
* remove persistence that will probably be user defined storage
* add missing persistence from values
* fix openldap volclaim
* remove persistence that will probably be user defined storage
* add missing persistence from values
* fix path ff3
* fix mountPath
* add missing persistence from values
* remove persistence that will probably be user defined storage
* revert changes in volClaimTemplate
* remove varrun from questions
* fix and cleanup questions postgres
* calm down CI
* ci only value
* fix min value on minio
* update service UI on LMS
* remove duplicate required from authelia
* remove Duplicate port defaults
* fix nextcloud duplicate required
* fix nullserv services
* fix plex duplicate default
* fix syncthing duplicate required
* syncthing replace code with include
* teamspeak replace code with include
* fix traefik duplicate required
* Unifi replace code with include
* Update label/description on `port` section
* remove type on nullserv's service
* remove extra space
* lowercase port names
* also lowercase service name omada
* update deployment settings
* hide securityContext by default
* replace bottom persistence section with include
* temporaryly remove hostPathType
* Cleanup basic persistence settings
* Allow simplePVC to also be used for volumeClaimTemplates
Stavros Kois