**Description**
<!--
Please include a summary of the change and which issue is fixed. Please
also include relevant motivation and context. List any dependencies that
are required for this change.
-->
⚒️ Fixes # <!--(issue)-->
TODO: Switch to scripted checks (To replace ct-list's tasks):
- [x] Helm Lint
- [x] Version Checking
- [x] Run the lint inside the devcontainer (so it have the below tools
available)
- [x] YAML Schema check on Chart.yaml
- [ ] Maintener check on Chart.yaml (Moved to another PR in the future)
- [x] YAML Lint on Chart.yaml
- [x] YAML Lint on values.yaml
- [x] Sort output of lint results (failed on the bottom)
- [x] Combine verify deps in the lint job, since the verification runs
inside the fetch dep (which runs on lint job too)
- [x] Remove one of the 2 "get changed" functions (one based on tags
other on commit)
After that, move linting to single step
https://github.com/helm/chart-testing/blob/main/pkg/tool/linter.gohttps://github.com/helm/chart-testing/blob/main/pkg/tool/account.go
**⚙️ Type of change**
- [ ] ⚙️ Feature/App addition
- [ ] 🪛 Bugfix
- [ ] ⚠️ Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [x] 🔃 Refactor of current code
**🧪 How Has This Been Tested?**
<!--
Please describe the tests that you ran to verify your changes. Provide
instructions so we can reproduce. Please also list any relevant details
for your test configuration
-->
**📃 Notes:**
<!-- Please enter any other relevant information here -->
**✔️ Checklist:**
- [x] ⚖️ My code follows the style guidelines of this project
- [x] 👀 I have performed a self-review of my own code
- [x] #️⃣ I have commented my code, particularly in hard-to-understand
areas
- [x] 📄 I have made corresponding changes to the documentation
- [x] ⚠️ My changes generate no new warnings
- [x] 🧪 I have added tests to this description that prove my fix is
effective or that my feature works
- [x] ⬆️ I increased versions for any altered app according to semantic
versioning
**➕ App addition**
If this PR is an app addition please make sure you have done the
following.
- [ ] 🪞 I have opened a PR on
[truecharts/containers](https://github.com/truecharts/containers) adding
the container to TrueCharts mirror repo.
- [ ] 🖼️ I have added an icon in the Chart's root directory called
`icon.png`
---
_Please don't blindly check all the boxes. Read them and only check
those that apply.
Those checkboxes are there for the reviewer to see what is this all
about and
the status of this PR with a quick glance._
**Description**
<!--
Please include a summary of the change and which issue is fixed. Please
also include relevant motivation and context. List any dependencies that
are required for this change.
-->
⚒️ Fixes # <!--(issue)-->
**⚙️ Type of change**
- [ ] ⚙️ Feature/App addition
- [ ] 🪛 Bugfix
- [ ] ⚠️ Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] 🔃 Refactor of current code
**🧪 How Has This Been Tested?**
<!--
Please describe the tests that you ran to verify your changes. Provide
instructions so we can reproduce. Please also list any relevant details
for your test configuration
-->
**📃 Notes:**
<!-- Please enter any other relevant information here -->
**✔️ Checklist:**
- [ ] ⚖️ My code follows the style guidelines of this project
- [ ] 👀 I have performed a self-review of my own code
- [ ] #️⃣ I have commented my code, particularly in hard-to-understand
areas
- [ ] 📄 I have made corresponding changes to the documentation
- [ ] ⚠️ My changes generate no new warnings
- [ ] 🧪 I have added tests to this description that prove my fix is
effective or that my feature works
- [ ] ⬆️ I increased versions for any altered app according to semantic
versioning
**➕ App addition**
If this PR is an app addition please make sure you have done the
following.
- [ ] 🪞 I have opened a PR on
[truecharts/containers](https://github.com/truecharts/containers) adding
the container to TrueCharts mirror repo.
- [ ] 🖼️ I have added an icon in the Chart's root directory called
`icon.png`
---
_Please don't blindly check all the boxes. Read them and only check
those that apply.
Those checkboxes are there for the reviewer to see what is this all
about and
the status of this PR with a quick glance._
* chore(questions): replace port parts with templates
* chore(questions): replace controller parts with templates
* remove tons of whitespce
* remove quotes from strings on templates
* make complete controller an include
* default to recreate
* remove replica and strategies as it's covered from controllerStrtegies include
* remove whitespace again
* replace controllertype with include (deployment/daemonset/statefulset)
* replace advanced port part except targetport
* remove more quotes
* add hidden toggle of enable the port
* new includes
* update build script
* controller deploy/stateful/deamon template changes
* replace controllerStrategies with replicas, replica#, strategy, recreate
* move 2 templates into a subfolder
* remove quotes
* remove disabled portals from questions and defined them on values
* remove enabled portal from the questions and add it on values
* one more app
* Portal cleanup
* remove portal templates
* add more includes
* replace portal links
* move some templates in folders
* replace ingressRoot with template
* more grouping
* replace persistenceroot with template
* replace serviceExpertRoot
* replace serviceroot
* fix a rogue one
* vctRoot
* securityContext cleanup
* remove quotes from templates on string
* replace vctRoot
* replace advanedSecurityRoot
* replace podsecurity root
* Update .github/scripts/build-catalog.sh
* Update values.yaml
* remove dupe portal
* update build-release script
* fix paths
* fix apps with imageSelector
Co-authored-by: Kjeld Schouten-Lebbing <kjeld@schouten-lebbing.nl>
* fix(apps): move conflicting ports to 10xxx range
* remove `protocol: TCP` as its the default anyway
* Change `"HTTP"` -> `HTTP` to much common
* lms udp port should be udp protocol
* resolve some conflicts
* clear port 80 conficts
* clean 3000 and 5000 port conflicts
* more conflict cleaning
* more conflict cleaning
* more cleanup
* more
* cleanup
* Avoid confclicts with official apps
* chore(apps): remove persistence size from values
* remove type from persistence from values.yaml
* remove accessMode from persistence from values
* devices dont user persistence
* remove empty lines
* restore accessMode in common, whoops
* quote all mountPaths
* convert `'` to `"`
* fix empty lines
* add missing mountPath on values
* add missing persistence on values
* fix var name on quetsions
* remove disabled persistence from values which are not even defined in questions
* remove more type, accessMode and size
* mountpath -> mountPath
* mounthPath -> mountPath
* booksonic-air persistence cleanup
* remove empty lines
* fix mountPath
* remove unused persistence
* teamspeak3 fix var name in persistence
* remove persistence that will probably be user defined storage
* remove persistence that will probably be user defined storage
* add missing persistence from values
* fix openldap volclaim
* remove persistence that will probably be user defined storage
* add missing persistence from values
* fix path ff3
* fix mountPath
* add missing persistence from values
* remove persistence that will probably be user defined storage
* revert changes in volClaimTemplate
* remove varrun from questions
* fix and cleanup questions postgres
* calm down CI
* ci only value
TrueCharts Bot