Cloned2Preserve
/
TrueChartsClone
mirror of https://github.com/truecharts/charts.git
1
0
Fork 0
Code
TrueChartsClone/charts/stable/minecraft-java
History
Ed P 9b0c330811
fix(minecraft-java): mcbackup wrong service name in host (#17089) 
**Description**
The "mcbackup" container in the minecraft-java chart was not working
properly due to the RCON port and backup mounts, as well as a minor typo
in the default backup interval.

I run a Minecraft server via this chart and was unable to backup using
the built in option, but this chart update corrects the issues I was
having.

⚒️ Fixes  # <!--(issue)-->

**⚙️ Type of change**

- [ ] ⚙️ Feature/App addition
- [X] 🪛 Bugfix
- [ ] ⚠️ Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] 🔃 Refactor of current code

**🧪 How Has This Been Tested?**
Tested using TrueNAS SCALE installation via Helm. Logs of the mcbackup
container were audited and tested repeatedly as well as tested the
backup archive themselves.

**📃 Notes:**
<!-- Please enter any other relevant information here -->

**✔️ Checklist:**

- [X] ⚖️ My code follows the style guidelines of this project
- [X] 👀 I have performed a self-review of my own code
- [ ] #️⃣ I have commented my code, particularly in hard-to-understand
areas
- [ ] 📄 I have made corresponding changes to the documentation
- [X] ⚠️ My changes generate no new warnings
- [ ] 🧪 I have added tests to this description that prove my fix is
effective or that my feature works
- [X] ⬆️ I increased versions for any altered app according to semantic
versioning

**➕ App addition**

If this PR is an app addition please make sure you have done the
following.

- [ ] 🪞 I have opened a PR on
[truecharts/containers](https://github.com/truecharts/containers) adding
the container to TrueCharts mirror repo.
- [ ] 🖼️ I have added an icon in the Chart's root directory called
`icon.png`

---

_Please don't blindly check all the boxes. Read them and only check
those that apply.
Those checkboxes are there for the reviewer to see what is this all
about and
the status of this PR with a quick glance._

---------

Co-authored-by: Stavros Kois <47820033+stavros-k@users.noreply.github.com>
 		2024-01-15 00:53:13 +02:00
..
ci
…
docs chore(docs): standardize ./img references (#16704) 2023-12-31 22:39:31 +02:00
templates feat(minecraft-java) add mc-backup sidecar (#10474) 2023-12-20 13:02:35 +01:00
.helmignore
…
CHANGELOG.md chore(docs): lints some docs, uses front-matter instead of # h1, and fix list items in changelog (#16589) 2023-12-31 16:24:05 +02:00
Chart.yaml fix(minecraft-java): mcbackup wrong service name in host (#17089) 2024-01-15 00:53:13 +02:00
README.md Commit daily changes 2024-01-01 00:10:30 +00:00
icon.png
…
questions.yaml fix(minecraft-java): mcbackup wrong service name in host (#17089) 2024-01-15 00:53:13 +02:00
values.yaml fix(minecraft-java): mcbackup wrong service name in host (#17089) 2024-01-15 00:53:13 +02:00

README.md

title
README

General Info

TrueCharts can be installed as both normal Helm Charts or as Apps on TrueNAS SCALE. However only installations using the TrueNAS SCALE Apps system are supported.

For more information about this App, please check the docs on the TrueCharts website

This chart is not maintained by the upstream project and any issues with the chart should be raised here

Support

Sponsor TrueCharts

TrueCharts can only exist due to the incredible effort of our staff. Please consider making a donation or contributing back to the project any way you can!

All Rights Reserved - The TrueCharts Project