Cloned2Preserve
/
TrueChartsClone
mirror of https://github.com/truecharts/charts.git
1
0
Fork 0
Code
TrueChartsClone/charts/stable/docker-compose
History
Jordan Woyak 7acee53c3e
fix(docker-compose): postStart execution. (#12472) 
**Description**
The docker-compose app is currently known to not properly launch on
TrueNAS Scale. Discord is filled with suggestions to manually shell into
the app and run `docker-compose up`. This is of course not a real
solution.

Based on this documentation I have moved the `lifecycle` section in
`values.yaml`:
https://truecharts.org/manual/helm/common/container/lifecycle/

⚒️ Fixes  #6439 (possibly related issue)

**⚙️ Type of change**

- [ ] ⚙️ Feature/App addition
- [x] 🪛 Bugfix
- [ ] ⚠️ Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] 🔃 Refactor of current code

**🧪 How Has This Been Tested?**
I have manually updated the `ix_values.yaml` in my `ix_applications`
directory to test this change. The app now runs as expected.

**📃 Notes:**
I have very little knowledge of this entire system. I have only tested
this on my "TrueNAS-SCALE-22.12.3.3" setup. If this app is supposed to
run elsewhere, I haven't tested it, but I will mention that my changes
are similar to what is already being done here in an unrelated app:
75ad318c25/charts/stable/piwigo/values.yaml (L31-L45)

**✔️ Checklist:**

- [ ] ⚖️ My code follows the style guidelines of this project
- [x] 👀 I have performed a self-review of my own code
- [ ] #️⃣ I have commented my code, particularly in hard-to-understand
areas
- [ ] 📄 I have made corresponding changes to the documentation
- [ ] ⚠️ My changes generate no new warnings
- [ ] 🧪 I have added tests to this description that prove my fix is
effective or that my feature works
- [x] ⬆️ I increased versions for any altered app according to semantic
versioning

---------

Signed-off-by: Jordan Woyak <jordan.woyak@gmail.com>
Signed-off-by: StevenMcElligott <89483932+StevenMcElligott@users.noreply.github.com>
Signed-off-by: Stavros Kois <47820033+stavros-k@users.noreply.github.com>
Co-authored-by: StevenMcElligott <89483932+StevenMcElligott@users.noreply.github.com>
Co-authored-by: Stavros Kois <47820033+stavros-k@users.noreply.github.com>
 		2023-09-16 08:49:10 +00:00
..
templates
…
.helmignore
…
CHANGELOG.md
…
Chart.yaml fix(docker-compose): postStart execution. (#12472) 2023-09-16 08:49:10 +00:00
README.md
…
icon.png
…
questions.yaml fix(docker-compose): postStart execution. (#12472) 2023-09-16 08:49:10 +00:00
values.yaml fix(docker-compose): postStart execution. (#12472) 2023-09-16 08:49:10 +00:00

README.md

README

General Info

TrueCharts can be installed as both normal Helm Charts or as Apps on TrueNAS SCALE. However only installations using the TrueNAS SCALE Apps system are supported.

For more information about this App, please check the docs on the TrueCharts website

This chart is not maintained by the upstream project and any issues with the chart should be raised here

Support

Sponsor TrueCharts

TrueCharts can only exist due to the incredible effort of our staff. Please consider making a donation or contributing back to the project any way you can!

All Rights Reserved - The TrueCharts Project