TrueChartsClone/templates
Michael Walter Van Der Velden 7d15dc372f
feat(ingressAdvanced): use tc-opencors-chain if allow-cors is enabled (#13240)
**Description**
<!--
Please include a summary of the change and which issue is fixed. Please
also include relevant motivation and context. List any dependencies that
are required for this change.
-->
⚒️ Allows for the optional use of the existing Traefik CORS setup for
Apps as CORS is required to use the official [jellyfin-vue
client](https://github.com/jellyfin/jellyfin-vue). Has been updated to
rely on https://github.com/truecharts/library-charts/pull/530

**⚙️ Type of change**

- [ ] ⚙️ Feature/App addition
- [x] 🪛 Bugfix
- [ ] ⚠️ Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] 🔃 Refactor of current code

**🧪 How Has This Been Tested?**
Manually edited the chart's files on my own TrueNas Scale Server.
Checked that jellyffin was using the tf-opencors-chain in Traefik rather
than basic-chain and ensured I could connect to jellyfin via a custom
app of [jellyfin-vue client](https://github.com/jellyfin/jellyfin-vue)
when the added config was enabled but not if disabled.

<img width="447" alt="Evidence of the correct chain being used in
Traefik"
src="https://github.com/truecharts/charts/assets/9092863/19a44a4e-fe95-4659-998b-753f4c4dbb4b">
<br>
<img width="213" alt="Added config option"
src="https://github.com/truecharts/charts/assets/9092863/a254c469-add2-49bf-85da-d0d17b371d7a">



**📃 Notes:**
<!-- Please enter any other relevant information here -->
This PR uses the same cors middleware setup as the existing
[audiobookshelf](eec761785c/charts/stable/audiobookshelf)
app to ensure conistancy. While it may be expected that the
`tf-opencors-headers` middleware could be added within the UI this
unfortunately results in the `Access-Control-Allow-Origin` header still
being missing as the common chain conflicts.

**✔️ Checklist:**

- [x] ⚖️ My code follows the style guidelines of this project
- [x] 👀 I have performed a self-review of my own code
- [x] #️⃣ I have commented my code, particularly in hard-to-understand
areas
- [ ] 📄 I have made corresponding changes to the documentation
- [x] ⚠️ My changes generate no new warnings
- [ ] 🧪 I have added tests to this description that prove my fix is
effective or that my feature works
- [ ] ⬆️ I increased versions for any altered app according to semantic
versioning

** App addition**

If this PR is an app addition please make sure you have done the
following.

- [ ] 🪞 I have opened a PR on
[truecharts/containers](https://github.com/truecharts/containers) adding
the container to TrueCharts mirror repo.
- [ ] 🖼️ I have added an icon in the Chart's root directory called
`icon.png`

---

_Please don't blindly check all the boxes. Read them and only check
those that apply.
Those checkboxes are there for the reviewer to see what is this all
about and
the status of this PR with a quick glance._

---------

Signed-off-by: Michael Walter Van Der Velden <mikevdv@vandie.co.uk>
2023-11-03 12:30:20 +01:00
..
chart chore(deps): update helm chart common to 14.2.2 (#14190) 2023-11-01 13:05:20 +01:00
docs Update some links in the docs (#9839) 2023-06-23 08:53:11 +02:00
questions feat(ingressAdvanced): use tc-opencors-chain if allow-cors is enabled (#13240) 2023-11-03 12:30:20 +01:00
README.md.tpl Update some links in the docs (#9839) 2023-06-23 08:53:11 +02:00
security.tpl
trivy-config.tpl
trivy-container.tpl fix(docs): remove container security scan links, as there are simply too-many 2022-12-23 20:45:18 +01:00

README.md.tpl

# README

## General Info

TrueCharts can be installed as both *normal* Helm Charts or as Apps on TrueNAS SCALE.
However only installations using the TrueNAS SCALE Apps system are supported.

For more information about this App, please check the docs on the TrueCharts [website](https://truecharts.org/charts/TRAINPLACEHOLDER/CHARTPLACEHOLDER)

**This chart is not maintained by the upstream project and any issues with the chart should be raised [here](https://github.com/truecharts/charts/issues/new/choose)**


## Support

- Please check our [quick-start guides for TrueNAS SCALE](https://truecharts.org/manual/SCALE/guides/scale-intro).
- See the [Website](https://truecharts.org)
- Check our [Discord](https://discord.gg/tVsPTHWTtr)
- Open a [issue](https://github.com/truecharts/charts/issues/new/choose)

---

## Sponsor TrueCharts

TrueCharts can only exist due to the incredible effort of our staff.
Please consider making a [donation](https://truecharts.org/sponsor) or contributing back to the project any way you can!

*All Rights Reserved - The TrueCharts Project*