Cloned2Preserve
/
TrueChartsClone
mirror of https://github.com/truecharts/charts.git
1
0
Fork 0
Code
TrueChartsClone/charts/stable/omada-controller
History
Aaron Dalton 8060a3bf8c
major(omada-controller): stop playing around with the port, let omada-controller handle it (#16719) 
**Description**

The Omada chart by default silently changes the internal port to use if
ingress is enabled. My understanding was the upstream container always
exposed 443 internally which needed to be remapped to not conflict with
the default Truenas web server. This seems to no-longer be the case so I
propose this weird silent behavior be removed.

This PR accomplishes this. 

⚒️ Fixes  # <!--(issue)-->

**⚙️ Type of change**

- [ ] ⚙️ Feature/App addition
- [ X ] 🪛 Bugfix
- [ ] ⚠️ Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] 🔃 Refactor of current code

**🧪 How Has This Been Tested?**

Not yet - but I'm interested to know the best way to test this. 

**📃 Notes:**

Currently it appears that setting the port works against the upstream
container at least on the initial install. Subesequent changes would
require changing the port in the UI before changing in Truecharts.

**✔️ Checklist:**

- [ X ] ⚖️ My code follows the style guidelines of this project
- [ X ] 👀 I have performed a self-review of my own code
- [ X ] #️⃣ I have commented my code, particularly in hard-to-understand
areas
- [ ] 📄 I have made corresponding changes to the documentation
- [ ] ⚠️ My changes generate no new warnings
- [ ] 🧪 I have added tests to this description that prove my fix is
effective or that my feature works
- [ ] ⬆️ I increased versions for any altered app according to semantic
versioning

**➕ App addition**

If this PR is an app addition please make sure you have done the
following.

- [ ] 🪞 I have opened a PR on
[truecharts/containers](https://github.com/truecharts/containers) adding
the container to TrueCharts mirror repo.
- [ ] 🖼️ I have added an icon in the Chart's root directory called
`icon.png`

---

_Please don't blindly check all the boxes. Read them and only check
those that apply.
Those checkboxes are there for the reviewer to see what is this all
about and
the status of this PR with a quick glance._

---------

Signed-off-by: Stavros Kois <47820033+stavros-k@users.noreply.github.com>
Co-authored-by: Aaron Dalton <zenoftheblues@gmail.com>
Co-authored-by: Stavros Kois <47820033+stavros-k@users.noreply.github.com>
 		2024-01-12 22:58:54 +02:00
..
docs chore(docs): standardize ./img references (#16704) 2023-12-31 22:39:31 +02:00
templates major(omada-controller): stop playing around with the port, let omada-controller handle it (#16719) 2024-01-12 22:58:54 +02:00
.helmignore
…
CHANGELOG.md chore(docs): lints some docs, uses front-matter instead of # h1, and fix list items in changelog (#16589) 2023-12-31 16:24:05 +02:00
Chart.yaml major(omada-controller): stop playing around with the port, let omada-controller handle it (#16719) 2024-01-12 22:58:54 +02:00
README.md Commit daily changes 2024-01-01 00:10:30 +00:00
icon.png
…
questions.yaml chore(questions): remove non-existent template refs (#16738) 2024-01-01 21:28:20 +02:00
values.yaml major(omada-controller): stop playing around with the port, let omada-controller handle it (#16719) 2024-01-12 22:58:54 +02:00

README.md

title
README

General Info

TrueCharts can be installed as both normal Helm Charts or as Apps on TrueNAS SCALE. However only installations using the TrueNAS SCALE Apps system are supported.

For more information about this App, please check the docs on the TrueCharts website

This chart is not maintained by the upstream project and any issues with the chart should be raised here

Support

Sponsor TrueCharts

TrueCharts can only exist due to the incredible effort of our staff. Please consider making a donation or contributing back to the project any way you can!

All Rights Reserved - The TrueCharts Project