fix(adguardhome-sync): deprecated variable update, boolean values (#22694)

**Description**
See deprecation notice here:
[https://github.com/bakito/adguardhome-sync/wiki/Deprecations#deprecation-of-environment-variables-as-of-v060](https://github.com/bakito/adguardhome-sync/wiki/Deprecations#deprecation-of-environment-variables-as-of-v060)

Also change boolean values to bool instead of string, hopefully fixes
this error when running `heavyscript update` on Scale:
```
adguardhome-sync
Failed to update. Manual intervention may be required.
Validation errors:
* values.workload.main.podSpec.containers.main.env.FEATURES_CLIENTSETTINGS: Not a boolean
* values.workload.main.podSpec.containers.main.env.FEATURES_DHCP_SERVERCONFIG: Not a boolean
* values.workload.main.podSpec.containers.main.env.FEATURES_DHCP_STATICLEASES: Not a boolean
* values.workload.main.podSpec.containers.main.env.FEATURES_DNS_ACCESSLISTS: Not a boolean
* values.workload.main.podSpec.containers.main.env.FEATURES_DNS_REWRITES: Not a boolean
* values.workload.main.pod...
For full error details, visit TrueNAS SCALE GUI: Check the Jobs icon and select your failed job.
```

**⚙️ Type of change**

- [ ] ⚙️ Feature/App addition
- [x] 🪛 Bugfix
- [ ] ⚠️ Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] 🔃 Refactor of current code

**🧪 How Has This Been Tested?**
It has not. If there is a good way for me to test, let me know and I
will.

**📃 Notes:**
Not sure if changing variable names is breaking, will people have to
reinput them? If so close and I can bump minor version instead of patch.
Or if there's a way to direct the chart how to rename current values let
me know and I'll do that.

**✔️ Checklist:**

- [x] ⚖️ My code follows the style guidelines of this project
- [x] 👀 I have performed a self-review of my own code
- [ ] #️⃣ I have commented my code, particularly in hard-to-understand
areas
- [ ] 📄 I have made corresponding changes to the documentation
- [ ] ⚠️ My changes generate no new warnings
- [ ] 🧪 I have added tests to this description that prove my fix is
effective or that my feature works
- [x] ⬆️ I increased versions for any altered app according to semantic
versioning
- [x] I made sure the title starts with `feat(chart-name):`,
`fix(chart-name):` or `chore(chart-name):`

** App addition**

If this PR is an app addition please make sure you have done the
following.

- [ ] 🖼️ I have added an icon in the Chart's root directory called
`icon.png`

---

_Please don't blindly check all the boxes. Read them and only check
those that apply.
Those checkboxes are there for the reviewer to see what is this all
about and
the status of this PR with a quick glance._

---------

Signed-off-by: Morgan Hunter <32530812+mxc42@users.noreply.github.com>
This commit is contained in:
Morgan Hunter 2024-05-31 11:32:41 -04:00 committed by GitHub
parent 71b9c7cd45
commit 6aecb283bb
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 15 additions and 15 deletions

View File

@ -34,4 +34,4 @@ sources:
- https://github.com/bakito/adguardhome-sync/ - https://github.com/bakito/adguardhome-sync/
- https://github.com/truecharts/charts/tree/master/charts/stable/adguardhome-sync - https://github.com/truecharts/charts/tree/master/charts/stable/adguardhome-sync
type: application type: application
version: 7.0.11 version: 7.0.12

View File

@ -21,23 +21,23 @@ workload:
- run - run
env: env:
CRON: "*/10 * * * *" CRON: "*/10 * * * *"
FEATURES_CLIENTSETTINGS: "true" FEATURES_CLIENT_SETTINGS: true
FEATURES_DHCP_SERVERCONFIG: "true" FEATURES_DHCP_SERVER_CONFIG: true
FEATURES_DHCP_STATICLEASES: "true" FEATURES_DHCP_STATIC_LEASES: true
FEATURES_DNS_ACCESSLISTS: "true" FEATURES_DNS_ACCESS_LISTS: true
FEATURES_DNS_REWRITES: "true" FEATURES_DNS_REWRITES: true
FEATURES_DNS_SERVERCONFIG: "true" FEATURES_DNS_SERVER_CONFIG: true
FEATURES_FILTERS: "true" FEATURES_FILTERS: true
FEATURES_GENERALSETTINGS: "true" FEATURES_GENERAL_SETTINGS: true
FEATURES_QUERYLOGCONFIG: "true" FEATURES_QUERY_LOG_CONFIG: true
FEATURES_SERVICES: "true" FEATURES_SERVICES: true
FEATURES_STATSCONFIG: "true" FEATURES_STATS_CONFIG: true
ORIGIN_PASSWORD: password ORIGIN_PASSWORD: password
ORIGIN_URL: https://192.168.1.2:3000 ORIGIN_URL: https://192.168.1.2:3000
ORIGIN_USERNAME: username ORIGIN_USERNAME: username
REPLICA_AUTOSETUP: "false" REPLICA_AUTO_SETUP: false
REPLICA_INTERFACENAME: "" REPLICA_INTERFACE_NAME: ""
REPLICA_PASSWORD: password REPLICA_PASSWORD: password
REPLICA_URL: http://192.168.1.3 REPLICA_URL: http://192.168.1.3
REPLICA_USERNAME: username REPLICA_USERNAME: username
RUNONSTART: "true" RUN_ON_START: true